307874 - Either wrong url or no url is shown in the status bar for focused links during FAYT

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P1)

Description

[Asaf Romano (gone)]

Either wrong url or no url is shown in the status bar for focused links during FAYT.

STR:
 1. Optional - focus a link
 2. Search for another link in the page using FAYT

-> The link is focused but the statusbar text isn't updated.

This looks like a regression from our pseudo-focus behavior.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: testcase of shift_jis

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: testcase of euc-jp

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: testcase of utf-8

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: testcase of frameset

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.1

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.2

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.2

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.3

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 195568 [details] [diff] [review]
Patch rv1.3

>+  var docCharset;
>+  var ownerDoc = gFoundLink.ownerDocument;
>+  if (ownerDoc)
>+    docCharset = ownerDoc.characterSet;
>+  else
>+    docCharset = "";

just init docCharset to "" and drop the else statement here.

>+  var uri =
>+    gTextToSubURIService.unEscapeURIForUI(docCharset, gFoundLink.href);
>+  xulBrowserWindow.setOverLink(uri);

please use url instead of uri when we're not dealing with an nsIURI

sorry for the delay on this.

Comment 11

[Scott MacGregor]

Comment on attachment 195568 [details] [diff] [review]
Patch rv1.3

should we get this checked into the trunk ASAP for a day of baking?

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch for check-in

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in to trunk and 1.8branch.

Comment 14

[Asaf Romano (gone)]

*** Bug 250483 has been marked as a duplicate of this bug. ***