The default bug view has changed. See this FAQ.

Nullplugin never stops loading

RESOLVED FIXED in mozilla1.8beta5

Status

()

Core
Plug-ins
P1
normal
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

({fixed1.8, regression})

Trunk
mozilla1.8beta5
x86
Linux
fixed1.8, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

Steps to reproduce:
- Load http://biesi.damowmow.com/object/033.html
- observe that throbber doesn't stop, and that statusbar only shows ~50% done

I think that plugins code suspends the channel here and never resumes it...

bug 241592 should have fixed this, but it looks like that patch only changed
windows, not linux (nor mac, for that matter)

seamonkey linux gtk2 trunk, checkout finish: Sa Sep 10 13:12:00 CEST 2005
Created attachment 195534 [details] [diff] [review]
patch

turns out that mac doesn't necessarily need any changes (since it just consumes
any number of bytes, so it doesn't have this bug)

with this page, I get three nullplugins on the testcase! that matches all the
other platforms and expected behaviour :-)
Attachment #195534 - Flags: superreview?(darin)
Attachment #195534 - Flags: review?(jst)
Blocks: 1156
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta5
Blocks: 308038
Comment on attachment 195534 [details] [diff] [review]
patch

r=jst
Attachment #195534 - Flags: review?(jst) → review+

Comment 3

12 years ago
Comment on attachment 195534 [details] [diff] [review]
patch

sr=darin
Attachment #195534 - Flags: superreview?(darin) → superreview+
Checking in modules/plugin/samples/default/unix/npshell.c;
/cvsroot/mozilla/modules/plugin/samples/default/unix/npshell.c,v  <-- 
npshell.cnew revision: 1.19; previous revision: 1.18
done
Checking in modules/plugin/samples/unixprinting/npshell.c;
/cvsroot/mozilla/modules/plugin/samples/unixprinting/npshell.c,v  <-- 
npshell.cnew revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Comment on attachment 195534 [details] [diff] [review]
patch

makes it so that pages with the nullplugin actually finish loading. this does
not affect firefox (which doesn't use the nullplugin), but it improves the
behaviour for seamonkey on linux. low risk: similar code in the windows
nullplugin has worked fine for a long time.
Attachment #195534 - Flags: approval1.8b5?

Updated

12 years ago
Attachment #195534 - Flags: approval1.8b5? → approval1.8b5+
fixed on MOZILLA_1_8_BRANCH
Checking in modules/plugin/samples/default/unix/npshell.c;
/cvsroot/mozilla/modules/plugin/samples/default/unix/npshell.c,v  <--  npshell.c
new revision: 1.18.28.1; previous revision: 1.18
done
Checking in modules/plugin/samples/unixprinting/npshell.c;
/cvsroot/mozilla/modules/plugin/samples/unixprinting/npshell.c,v  <--  npshell.c
new revision: 1.2.28.1; previous revision: 1.2
done
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.