307879 - Nullplugin never stops loading

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Steps to reproduce:
- Load http://biesi.damowmow.com/object/033.html
- observe that throbber doesn't stop, and that statusbar only shows ~50% done

I think that plugins code suspends the channel here and never resumes it...

bug 241592 should have fixed this, but it looks like that patch only changed
windows, not linux (nor mac, for that matter)

seamonkey linux gtk2 trunk, checkout finish: Sa Sep 10 13:12:00 CEST 2005

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

turns out that mac doesn't necessarily need any changes (since it just consumes
any number of bytes, so it doesn't have this bug)

with this page, I get three nullplugins on the testcase! that matches all the
other platforms and expected behaviour :-)

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 195534 [details] [diff] [review]
patch

r=jst

Comment 3

[Darin Fisher]

Comment on attachment 195534 [details] [diff] [review]
patch

sr=darin

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in modules/plugin/samples/default/unix/npshell.c;
/cvsroot/mozilla/modules/plugin/samples/default/unix/npshell.c,v  <-- 
npshell.cnew revision: 1.19; previous revision: 1.18
done
Checking in modules/plugin/samples/unixprinting/npshell.c;
/cvsroot/mozilla/modules/plugin/samples/unixprinting/npshell.c,v  <-- 
npshell.cnew revision: 1.3; previous revision: 1.2
done

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 195534 [details] [diff] [review]
patch

makes it so that pages with the nullplugin actually finish loading. this does
not affect firefox (which doesn't use the nullplugin), but it improves the
behaviour for seamonkey on linux. low risk: similar code in the windows
nullplugin has worked fine for a long time.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on MOZILLA_1_8_BRANCH
Checking in modules/plugin/samples/default/unix/npshell.c;
/cvsroot/mozilla/modules/plugin/samples/default/unix/npshell.c,v  <--  npshell.c
new revision: 1.18.28.1; previous revision: 1.18
done
Checking in modules/plugin/samples/unixprinting/npshell.c;
/cvsroot/mozilla/modules/plugin/samples/unixprinting/npshell.c,v  <--  npshell.c
new revision: 1.2.28.1; previous revision: 1.2
done