Installing extensions with guids with a trailing / cause an unknown error.

RESOLVED FIXED

Status

()

Toolkit
Add-ons Manager
--
trivial
RESOLVED FIXED
12 years ago
9 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

({fixed1.8})

1.8.0 Branch
fixed1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
The test for valid guids in the extension manager allows a trailing /.
Installation then fails when trying to create a directory with that name with
the following error in the JavaScript console:

Error: [Exception... "Component returned failure code: 0x80520001
(NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.append]"  nsresult: "0x80520001
(NS_ERROR_FILE_UNRECOGNIZED_PATH)"  location: "JS frame ::
file:///C:/Program%20Files/Deer%20Park%20Alpha%202/components/nsExtensionManager.js
:: anonymous :: line 1085"  data: no]
Source File:
file:///C:/Program%20Files/Deer%20Park%20Alpha%202/components/nsExtensionManager.js
Line: 1085
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

12 years ago
Created attachment 195570 [details] [diff] [review]
patch

This patch simply removes the optional trailing slash from the regular
expression that is used to test for valid guids.

This is a pretty minor issue and should only really stop some confusion for
extension authors who might make the mistake.
Attachment #195570 - Flags: review?(rob_strong)
Attachment #195570 - Flags: review?(rob_strong) → review+
Benjamin - was there a reason the ext id regexp allowed an optional '/' on the
end of the id?
Ben wrote the original regexp: IIRC, it was checking directory names and he was
having problems with a trailing slash. I'm hoping that we changed to use
leafnames since then.
Thanks and that makes sense. I had already verified it does use the leafName
everywhere the regexp is used so this should be good to go.
Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.153; previous revision: 1.152
done
(Assignee)

Comment 6

12 years ago
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Comment on attachment 195570 [details] [diff] [review]
patch

asking for 1.8b5 so there is consistency for what are considered valid id's
between trunk and branch.
Attachment #195570 - Flags: approval1.8b5?

Updated

12 years ago
Attachment #195570 - Flags: approval1.8b5? → approval1.8b5+
Checked in on MOZILLA_1_8_BRANCH

Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.144.2.10; previous revision: 1.144.2.9

Thanks for the patch!
Keywords: fixed1.8
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.