Closed
Bug 307925
Opened 18 years ago
Closed 18 years ago
Installing extensions with guids with a trailing / cause an unknown error.
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mossop, Assigned: mossop)
Details
(Keywords: fixed1.8)
Attachments
(1 file)
1.20 KB,
patch
|
robert.strong.bugs
:
review+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
The test for valid guids in the extension manager allows a trailing /. Installation then fails when trying to create a directory with that name with the following error in the JavaScript console: Error: [Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.append]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: file:///C:/Program%20Files/Deer%20Park%20Alpha%202/components/nsExtensionManager.js :: anonymous :: line 1085" data: no] Source File: file:///C:/Program%20Files/Deer%20Park%20Alpha%202/components/nsExtensionManager.js Line: 1085
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•18 years ago
|
||
This patch simply removes the optional trailing slash from the regular expression that is used to test for valid guids. This is a pretty minor issue and should only really stop some confusion for extension authors who might make the mistake.
Attachment #195570 -
Flags: review?(rob_strong)
![]() |
||
Updated•18 years ago
|
Attachment #195570 -
Flags: review?(rob_strong) → review+
![]() |
||
Comment 2•18 years ago
|
||
Benjamin - was there a reason the ext id regexp allowed an optional '/' on the end of the id?
Comment 3•18 years ago
|
||
Ben wrote the original regexp: IIRC, it was checking directory names and he was having problems with a trailing slash. I'm hoping that we changed to use leafnames since then.
![]() |
||
Comment 4•18 years ago
|
||
Thanks and that makes sense. I had already verified it does use the leafName everywhere the regexp is used so this should be good to go.
Comment 5•18 years ago
|
||
Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in; /cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v <-- nsExtensionManager.js.in new revision: 1.153; previous revision: 1.152 done
Assignee | ||
Comment 6•18 years ago
|
||
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
![]() |
||
Comment 7•18 years ago
|
||
Comment on attachment 195570 [details] [diff] [review] patch asking for 1.8b5 so there is consistency for what are considered valid id's between trunk and branch.
Attachment #195570 -
Flags: approval1.8b5?
Updated•18 years ago
|
Attachment #195570 -
Flags: approval1.8b5? → approval1.8b5+
![]() |
||
Comment 8•18 years ago
|
||
Checked in on MOZILLA_1_8_BRANCH Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in; /cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v <-- nsExtensionManager.js.in new revision: 1.144.2.10; previous revision: 1.144.2.9 Thanks for the patch!
Keywords: fixed1.8
Updated•15 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•