This patch simply removes the optional trailing slash from the regular expression that is used to test for valid guids. This is a pretty minor issue and should only really stop some confusion for extension authors who might make the mistake.
Attachment #195570 - Flags: review?(rob_strong)
14 years ago
Attachment #195570 - Flags: review?(rob_strong) → review+
Benjamin - was there a reason the ext id regexp allowed an optional '/' on the end of the id?
Ben wrote the original regexp: IIRC, it was checking directory names and he was having problems with a trailing slash. I'm hoping that we changed to use leafnames since then.
Thanks and that makes sense. I had already verified it does use the leafName everywhere the regexp is used so this should be good to go.
Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in; /cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v <-- nsExtensionManager.js.in new revision: 1.153; previous revision: 1.152 done
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 195570 [details] [diff] [review] patch asking for 1.8b5 so there is consistency for what are considered valid id's between trunk and branch.
Attachment #195570 - Flags: approval1.8b5?
Attachment #195570 - Flags: approval1.8b5? → approval1.8b5+
Checked in on MOZILLA_1_8_BRANCH Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in; /cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v <-- nsExtensionManager.js.in new revision: 184.108.40.206; previous revision: 220.127.116.11 Thanks for the patch!
You need to log in before you can comment on or make changes to this bug.