All users were logged out of Bugzilla on October 13th, 2018

document pseudo-element code a little better

RESOLVED FIXED in mozilla1.9alpha1

Status

()

P4
normal
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla1.9alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(1 attachment)

Patch coming, with improved documentation and added assertions.
Created attachment 195577 [details] [diff] [review]
patch
Attachment #195577 - Flags: superreview?(bzbarsky)
Attachment #195577 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
Priority: -- → P4
Whiteboard: [patch]
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 195577 [details] [diff] [review]
patch

r+sr=bzbarsky
Attachment #195577 - Flags: superreview?(bzbarsky)
Attachment #195577 - Flags: superreview+
Attachment #195577 - Flags: review?(bzbarsky)
Attachment #195577 - Flags: review+
Fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
So it looks like a select with no options triggers the assert in
ProbePseudoStyleFor by calling it with nsCSSAnonBoxes::dummyOption as the pseudo
via CreateGeneratedContentFrame (called from
nsCSSFrameConstructor::AddDummyFrameToSelect).  Try loading
resource:///res/samples/test8.html to test.  This is the current orange on balsa.
I weakened the assertion to fix the orange.
You need to log in before you can comment on or make changes to this bug.