308026 - "Download Actions" dialog should be modal.

Status: RESOLVED DUPLICATE of bug 283613

(Firefox :: General, defect)

Description

[Nuno Gonçalo Brito]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

The "Download Actions" dialog which is reached via
"Tools"->"Options"->"Downloads"->"View & Edit Actions" is not a modal dialog.
This means that while it is open you can press the "Cancel" button in the parent
"Options" dialog and make the "Options" dialog go away and remain with the
"Download Actions" dialog open.

Reproducible: Always

Steps to Reproduce:
1.Select the "Tools->Options" menu entry.
2.Select the "Downloads" tab.
3.Click the "View & Edit Actions" button. This will make the "Download Actions"
dialog visible and a new icon will appear in the Windows's taskbar.
4.Select the "Options" dialog by clicking on it or on the Firefox's icon in the
taskbar. You will see the the "Download Actions" dialog will be hidden by the
Firefox's main window and "Options" dialog.
5.Click the "Cancel" button in the "Options" dialog. You will see that the
"Options" dialog will disappear but the "Download Actions" will remain open.
Actual Results:  
The "Download Actions" dialog remained open until I closed it. Since I had just
installed Firefox 1.5 Beta 1 I decided not to try and see what would happen if I
made modifications to the actions after having dismissed the parent "Options"
dialog.

Expected Results:  
You shouldn't be able to select the parent "Options" dialog while the "Download
Actions" dialog is open. You should be forced to close it before returning to
the "Options" dialog.

This was normal full installation of the official Mozilla Firefox version 1.5
Beta 1.
By "normal full installation" I mean a "custom" installation in which you select
all the modules and accept all the other defaults.

Comment 1

[Peter van der Woude [:Peter6]]

Confirmed

->New
->?1.8b5

Comment 2

[Dave Townsend [:mossop]]

There are a number of windows that open non-modal from the options. They should
all work fine (there is a definate bug if they don't). I spoke with mconnor
about this last night and he was happy that it was happening.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

See bug 283613 comment 2 and following comments.

*** This bug has been marked as a duplicate of 283613 ***

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Also, I don't see how it is beneficial in any way to make the dialog modal...
why should closing the Options dialog while the Download Actions window is open
be disallowed?

Comment 5

[Nuno Gonçalo Brito]

I didn't check other windows in Firefox 1.5 beta 1 but in Firefox 1.0.6 all the
windows launched from the Options dialog are also dialogs. In my view, that is
what the users are expecting (at least Microsoft Windows users).
What happens if you cancel the Options dialog but then make changes in the
Download Actions dialog? Are they commited? Are they discarded?
From my experience using Microsoft Windows, any window launched from a dialog is
itself a dialog or behaves like one, i.e. it is modal.

Comment 6

[Dave Townsend [:mossop]]

This bug has been duped to another. Any points you wish to raise should be
entered in the real bug or the people who made the decision in the first place
may well not see them.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #5)
> What happens if you cancel the Options dialog but then make changes in the
> Download Actions dialog? Are they commited? Are they discarded?

They are committed. The "download actions dialog" isn't a dialog, it's a window.