308069 - Teach Firefox to figure out OS's theme and set menu style accordingly.

Status: RESOLVED DUPLICATE of bug 243078

(Firefox :: Menus, enhancement)

Description

[u88484]

Teach Firefox to figure out OS's theme and set menu styles accordingly (either
classic or luna stlye menus) until Native theme rendering is fixed....then back
it out. Short term fix for all of the pissed off people about Bug# 303806. We
take other band-aids just like the patch in 303806 so we should include this...

Patch is in the works

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Native theme rendering is being worked on... See bug 243078. More "band-aids"
aren't the way to go.

Comment 2

[Asaf Romano (gone)]

Duplicating to that bug.

*** This bug has been marked as a duplicate of 243078 ***

Comment 3

[Grayson Mixon (ColdFusion650)]

will native theme rendering be in 1.5b2 or 1.5? if it is, fine. if its not, this
is the way to go.

Comment 4

[u88484]

This isn't a dupe of that bug, that one is about native rendering. This is about
using a custom .css file (which is the classic menu style that was once used by
firefox) and the ability for the user to choose if they want luna style menus or
classic menus, also default would be auto detect based on OS settings. What if
Bug# 243078 isn't fixed in time for beta2?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

It's either INVALID or WONTFIX, then. The only proper way to do this is with
native rendering.

Comment 6

[Grayson Mixon (ColdFusion650)]

if native rendering makes it into b2. otherwise, until native rendering gets
fixed, this is the better solution.

Comment 7

[u88484]

And if Bug# 243078 does not make 1.5 there will be even more pissed off people
thinking Firefox is ugly. The way we are proposing uses about 40 lines of code
if that to add a about:config integer to change teh theme to either 0-classic
1-luna 2-auto-detect based on OS theme. can tell if your on XP and using classic
then it loads out menu.css file if on luna then stays with what is now the
firefox default. It is low risk. And if bug 243078 is fixed in time and suitable
then back out our patch, it would take a whole what 30 seconds to back it out.
30 seconds to keep a crap load of your users happy is priceless!

Comment 8

[Ben Basson]

I don't think this should be duped / wontfixed... if the people complaining
about the menu changes want to do something that is viable for Firefox 1.5, I
don't see the harm in having a bug to that end.

If a simple, well-written patch materialises shortly, it would be nice if it
were at least considered (even if it is ultimately denied or simply a bandaid
for the problem).