Closed Bug 308079 Opened 19 years ago Closed 19 years ago

canHaveExplicitInherit seems unused

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: Biesinger, Assigned: dbaron)

References

()

Details

(Whiteboard: [patch])

Attachments

(1 file)

See URL - it gets assigned PR_FALSE initially and is then only read, once in
debug output, and once in an if.

/layout/style/nsRuleNode.cpp, line 918 -- PRBool canHaveExplicitInherit = PR_FALSE;
/layout/style/nsRuleNode.cpp, line 998 -- aSID, total, specified, inherited,
canHaveExplicitInherit?"true":"false");
/layout/style/nsRuleNode.cpp, line 1001 -- if (canHaveExplicitInherit) {
Yeah, looks like I missed this in bug 205790.
Attached patch patchSplinter Review
Attachment #195707 - Flags: superreview?(bzbarsky)
Attachment #195707 - Flags: review?(cbiesinger)
Severity: normal → trivial
Status: NEW → ASSIGNED
OS: Linux → All
Priority: -- → P4
Hardware: PC → All
Whiteboard: [patch]
Target Milestone: --- → mozilla1.9alpha
Attachment #195707 - Flags: superreview?(bzbarsky)
Attachment #195707 - Flags: superreview+
Attachment #195707 - Flags: review?(cbiesinger)
Attachment #195707 - Flags: review+
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: