308098 - Richlistbox error shown in JS console when DownloadMgr is opened

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Nobu Nari]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050911 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050911 Firefox/1.6a1 ID:2005091116

JS console shows the error of NS_ERROR_INVALID_POINTER when downloadmgr is opened.



Reproducible: Always

Steps to Reproduce:
1.Open download manager
2.Open javascript-console
3.

Actual Results:  
JS console shows the following error as
Error: [Exception... "Component returned failure code: 0x80004003
(NS_ERROR_INVALID_POINTER) [nsIScrollBoxObject.ensureElementIsVisible]" 
nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://global/content/bindings/richlistbox.xml :: ensureElementIsVisible ::
line 350"  data: no]
Source File: chrome://global/content/bindings/richlistbox.xml
Line: 350

Expected Results:  
There should be no-error.

Comment 1

[Nobu Nari]

When download histry is listed in the downloadmgr, js console does not show any
errors. 
However, if the list in the DLmgr is empty, the js error is displayed.

Comment 2

[Ria Klaassen (not reading all bugmail)]

I see this when the Download manager is opened but empty (only with
javascript.options.showInConsole to true):

Error: gDownloadManager has no properties
Source File: chrome://mozapps/content/downloads/downloads.js
Line: 698

Followed by three identical errors when I download a build:

Error: dialog has no properties
Source File: chrome://mozapps/content/downloads/unknownContentType.xul
Line: 1

This when I click Clean up or Remove:

Error: [Exception... "Component returned failure code: 0x80004003
(NS_ERROR_INVALID_POINTER) [nsIScrollBoxObject.ensureElementIsVisible]" 
nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://global/content/bindings/richlistbox.xml :: ensureElementIsVisible ::
line 350"  data: no]
Source File: chrome://global/content/bindings/richlistbox.xml
Line: 350

When I try to clear downloads that seem to stand still:

Error: gDownloadsView.clearSelection is not a function
Source File: chrome://mozapps/content/downloads/downloads.js
Line: 234

Comment 3

[Ria Klaassen (not reading all bugmail)]

This build works: 1.9a1_2005090206 
And this one fails: 1.9a1_2005090222

Comment 4

[Ria Klaassen (not reading all bugmail)]

Hm, I get also errors in BRANCH builds when I open the downloadmanager and when
I click Clean Up:

Error: [Exception... "Component returned failure code: 0x80004003
(NS_ERROR_INVALID_POINTER) [nsIScrollBoxObject.ensureElementIsVisible]" 
nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://global/content/bindings/richlistbox.xml :: ensureElementIsVisible ::
line 347"  data: no]
Source File: chrome://global/content/bindings/richlistbox.xml
Line: 347

Comment 5

[Simon Bünzli]

Attachment: Simple fix

This is a "regression" from bug 306522, where ensureSelectedElementIsVisible is
called without checking whether any element is actually selected. This patch
moves this test where it rather belongs (preventing further regressions of the
same kind).

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 196072 [details] [diff] [review]
Simple fix

>-            this.scrollBoxObject.ensureElementIsVisible(aElement);
>+            if (aElement != null)
>+              this.scrollBoxObject.ensureElementIsVisible(aElement);

if (aElement) should be enough here, and no SR is required in toolkit.

Comment 7

[Simon Bünzli]

Attachment: Nit resolved

Comment 8

[Asaf Romano (gone)]

Checking in richlistbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/richlistbox.xml,v  <--  richlistbox.xml
new revision: 1.20; previous revision: 1.19
done

Comment 9

[Asaf Romano (gone)]

Checking in richlistbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/richlistbox.xml,v  <--  richlistbox.xml
new revision: 1.13.2.6; previous revision: 1.13.2.5
done

Comment 10

[Nobu Nari]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050915
Firefox/1.6a1 ID:2005091517

Verified this fixed. Thanks!