Closed Bug 308114 Opened 19 years ago Closed 19 years ago

[Mac] No keyboard shortcut for "Highlight All"

Categories

(Toolkit :: Find Toolbar, defect, P2)

Product:
Toolkit
Component:
Find Toolbar
Version:
1.8.0 Branch
Platform:
PowerPC
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8final

People

(Reporter: asaf, Assigned: asaf)

References

Details

(Keywords: access, fixed1.8, late-l10n, Whiteboard: [l10n impact])

Attachments

(1 file)

patch
3.05 KB, patch
mconnor
: review+
mtschrep
: approval1.8b5+
Details | Diff | Splinter Review 
On mac, there's no keyboard shortcut for "Highlight All"; Ctrl+Enter doesn't
work on mac (and isn't really expected to). We should change it to Cmd+Enter and
also update the tooltip(!).
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Firefox1.5
Attached patch patch — — Splinter Review 

  

  



        Attachment #196388 -
        Flags: review?(mconnor)

    
  
Flags: blocking1.8b5?
Whiteboard: [l10n impact][needs review mconnor]

    
  
Keywords: late-l10n

    
    

    
  
Comment on attachment 196388 [details] [diff] [review]
patch

low-risk, we should approve this, but please cc firefoxl10n@hotmail.com and
announce properly.

  

  



        Attachment #196388 -
        Flags: review?(mconnor)

        Attachment #196388 -
        Flags: review+

        Attachment #196388 -
        Flags: approval1.8b5?

    
    

    
  
Checking in toolkit/locales/en-US/chrome/global/findbar.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/global/findbar.dtd,v  <--  findbar.dtd
new revision: 1.4; previous revision: 1.3
done
Checking in toolkit/components/typeaheadfind/content/findBar.inc;
/cvsroot/mozilla/toolkit/components/typeaheadfind/content/findBar.inc,v  <-- 
findBar.inc
new revision: 1.6; previous revision: 1.5
done
Checking in toolkit/components/typeaheadfind/content/findBar.js;
/cvsroot/mozilla/toolkit/components/typeaheadfind/content/findBar.js,v  <-- 
findBar.js
new revision: 1.25; previous revision: 1.24
done

  

  


Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

    
  
Whiteboard: [l10n impact][needs review mconnor] → [l10n impact]

    
  
Flags: blocking1.8b5? → blocking1.8b5+

    
    

    
  
Comment on attachment 196388 [details] [diff] [review]
patch

Approved for 1.8b5 per bug meeting

  

  



        Attachment #196388 -
        Flags: approval1.8b5? → approval1.8b5+

    
    

    
  
1.8 Branch:

Checking in toolkit/locales/en-US/chrome/global/findbar.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/global/findbar.dtd,v  <--  findbar.dtd
new revision: 1.3.4.1; previous revision: 1.3
done
Checking in toolkit/components/typeaheadfind/content/findBar.inc;
/cvsroot/mozilla/toolkit/components/typeaheadfind/content/findBar.inc,v  <-- 
findBar.inc
new revision: 1.4.4.2; previous revision: 1.4.4.1
done
Checking in toolkit/components/typeaheadfind/content/findBar.js;
/cvsroot/mozilla/toolkit/components/typeaheadfind/content/findBar.js,v  <-- 
findBar.js
new revision: 1.21.2.4; previous revision: 1.21.2.3
done

  

  


Keywords: fixed1.8

    
    

    
  
*** Bug 265909 has been marked as a duplicate of this bug. ***

  

  


Product: Firefox → Toolkit

    
    

    
  
https://bugzilla.mozilla.org/show_bug.cgi?id=1527381



  

  


Keywords: sec508

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: