308125 - http proxy setting allows newlines (characters; doesn't check erroneous long input)

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, defect)

Description

[Frank Wang]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; zh-CN; rv:1.7.10) Gecko/20050909 Fedora/1.0.6-1.2.fc4 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; zh-CN; rv:1.7.10) Gecko/20050909 Fedora/1.0.6-1.2.fc4 Firefox/1.0.6

I used to copy and paste searched proxy server list to http proxy setting in
preference. One time I mistakenly paste something more than the proxy ip address
 into the blank and after that proxy browsing alway fails, reporting "The proxy
server can't be found" error. The strange thing is that no matter whatever new
working proxy server ip typed in, same error always repeat. I didn't understand
until I opened prefs.js. There was a long line "user_pref("network.proxy.http",
"210.9.188.5\n...garbage....");" in it and those garbage was the content of the
web page I mistakenly selected. Manually edit prefs.js and delete extra stuff
solved the problem. 
Firefox should check user input data validity there before proceeding.


Reproducible: Always

Steps to Reproduce:
1. paste something more than ip address into http proxy setting which contains
line feed character.
2.
3.

Actual Results:  
proxy won't work anymore even correct one typed in later

Comment 1

[[:Aleksej]]

Confirmed with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a8pre) Gecko/2007091704 Minefield/3.0a8pre.
WFM with Thunderbird version 3.0a1pre (2007091703).

Comment 2

[RNicoletto]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10

Comment 3

[RNicoletto]

(In reply to comment #2)
> Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.10)
> Gecko/2009042316 Firefox/3.0.10

But WFM with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090529 Minefield/3.6a1pre

Comment 4

[Manish Goregaokar [:manishearth]]

Norepro (Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0)

When I try this, it converts the line break to a space. While this breaks the proxy handling (much like any other invalid proxy configuration), it's easily revertible.

Comment 5

[Manish Goregaokar [:manishearth]]

Norepro Windows, too.