308150 - admin/products/deleted.html.tmpl doesn't include admin/products/footer.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Frédéric Buclin]

admin/products/deleted.html.tmpl should have links to most common product pages,
i.e. should include admin/products/footer.html.tmpl.

Comment 1

[Frédéric Buclin]

Attachment: patch for the tip, v1

Comment 2

[Frédéric Buclin]

Attachment: backport for 2.20, v1

I backported the relevant part of the patch from bug 306242 about
admin/products/footer.html.tmpl which is still broken in 2.20 when
classifications are used.

Comment 3

[GavinS]

Comment on attachment 195730 [details] [diff] [review]
patch for the tip, v1

Just one minor issue: we need to set the classification template variable, so
the classification links are presented in the footer.

Comment 4

[Frédéric Buclin]

Attachment: patch for the tip, v2

fix Gavin's comment.

Comment 5

[Frédéric Buclin]

Attachment: backport for 2.20, v2

Gavin's comment applies to the backport too.

Comment 6

[GavinS]

Comment on attachment 195756 [details] [diff] [review]
patch for the tip, v2

Yes, tested, works. bug#308183 will refine the useclassification checks

Comment 7

[Dave Miller [:justdave]]

Holding approval for the 2.20 release (the tree is now locked down for release),
this'll go in 2.20.1.

Comment 8

[GavinS]

Comment on attachment 195757 [details] [diff] [review]
backport for 2.20, v2

And this one is OK as well

Comment 9

[Dave Miller [:justdave]]

ok, Fréd says we can take this one for 2.20 because they haven't started the
release testing yet.

Comment 10

[Frédéric Buclin]

tip:

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.98; previous revision: 1.97
done
Checking in template/en/default/admin/products/deleted.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/deleted.html.tmpl,v
 <--  deleted.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/products/footer.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/footer.html.tmpl,v
 <--  footer.html.tmpl
new revision: 1.5; previous revision: 1.4
done


2.20rc2:

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.85.2.5; previous revision: 1.85.2.4
done
Checking in template/en/default/admin/products/deleted.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/deleted.html.tmpl,v
 <--  deleted.html.tmpl
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in template/en/default/admin/products/footer.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/footer.html.tmpl,v
 <--  footer.html.tmpl
new revision: 1.3.2.1; previous revision: 1.3
done