308157 - VersionCheck.php does not list the newest version in some circumstances (?)

Status: RESOLVED DUPLICATE of bug 304857

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[balazs.ugron]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; hu-HU; rv:1.7.10) Gecko/20050717 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; hu-HU; rv:1.7.10) Gecko/20050717 Firefox/1.0.6

There are cases when checking for extension updates in Firefox (v1.06)
says the newest version of an extension is 'boo' though there are
newer approved (even on ftp.mozilla.org).

I know there are a similar bug filed but that is about version sorting
(for example 0.10.1 < 0.9.1), and in this case its about 0.1.1 vs 0.1.0 
(see reproducing below) which can't be a sort problem, IMO.




Reproducible: Always

Steps to Reproduce:
1. see
https://update.mozilla.org/update/VersionCheck.php?reqVersion=1.0%&id={73D01FEC-17C1-40cb-B0CB-5C01C03FF2F0}&version=0.0.9&maxAppVersion=1.0.6&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=1.0.6
2.
3.

Actual Results:  
VersionCheck.php lists 'Find in frame hack' extension version 0.1.0

Expected Results:  
Version 0.1.1 should be listed because it is approved since many days and the 
newer version can be downloaded from ftp.mozilla.org or https://addons.mozilla.org.

Comment 1

[Daniel Veditz [:dveditz]]

confirming. Another example is "Translation Panel" where it picks the year-old
1.4.3 version as the latest, rather than last April's 1.4.13 version. And then
apparently it uses the version compatibility from the version it selected and
doesn't show it to you if you've got Deer Park.

Comment 2

[Michael Morgan [:morgamic]]

I agree - this is a problem and would be solved by not relying on decimal-based
comparisons.  Implementing the patch for vercomp in PHP as a substitute for the
MySQL comparison is the easiest fix, so I am marking this as a duplicate of bug
304857.

*** This bug has been marked as a duplicate of 304857 ***

Comment 3

[Michael Morgan [:morgamic]]

AMO BUGSPAM FOR COMPONENT MOVE AND DELETE (FILTER ME)

Comment 4

[Reed Loden [:reed]]

AMO BUGSPAM FOR QACONTACT FIX (FILTER ME)