308240 - Changing Live Bookmark URL doesn't remove current items before loading new URL

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Phil Ringnalda (:philor)]

Hitting this real-world requires a nice slow connection, so that you can change
the URL and open the livemark folder before it updates to the new items from the
new URL, but you can get the same effect, with bonus breakage, by changing to an
unresponsive URL.

STR:
1. Start with a Live Bookmark on the bookmarks toolbar: the default "Latest
Headlines" is fine, but be sure you've scrolled down to the bottom of the items.
2. Right-click, Properties, change the Feed Location to
http://example.com:440/rss.xml
3. Click OK, then open the livemark folder, and you'll have a "Live Bookmark
loading" item at the bottom of the previous items.
4. Since it doesn't change, decide to right-click, Reload Live Bookmark - now
you have a completely broken empty livemark, without even a "Live Bookmark
failed to load" item.

With a non-broken URL, it just looks like it didn't work if you open the
livemark before it finishes loading, because you still see the same items (and
probably don't notice the "Live Bookmark loading..." at the bottom, especially
if there are enough items to have it scrolled off the bottom).

Comment 1

[Davor Cubranic]

I use a valid RSS field as the new URL value, and even after repeated refreshes
I don't see new entries in the live bookmark.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Screenshot: http://img369.imageshack.us/img369/2234/livemark9wm.png

Comment 3

[Phil Ringnalda (:philor)]

Attachment: patch

D'oh, I should have looked at whether it was a one-liner suitable for my limited skillz.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 223746 [details] [diff] [review]
patch

r+a=me

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Checked in on the branch. This isn't relevant to the trunk, right?
mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp 	1.67.2.10

Comment 6

[Phil Ringnalda (:philor)]

Only relevant to the trunk for -disable-places (which at least one person we know is using) - the Places version would be bug 331236 to have it even notice that the URL has been changed, and then we'll see if whoever does that remembers to remove old items.

Comment 7

[Phil Ringnalda (:philor)]

However, I can't close it as fixed until it's fixed on the trunk, where the file exists even if it isn't build by default. So, please?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp 	1.85