308294 - Thunderbird tinderbox (bg l10n) fails in "$(ZIP) -r9D $(LANGPACK_FILE) install.rdf chrome chrome.manifest"

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Ognyan Kulev]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; bg; rv:1.8b4) Gecko/20050803 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; bg; rv:1.8b4) Gecko/20050803 Firefox/1.0+

For Linux and Mac OS X builds of Thunderbird 1.5 localized for Bulgarian (bg), I
get the following error in Thunderbird logs:

...
cd ../../dist/xpi-stage/locale-bg && \
  /usr/bin/zip -r9D
/builds/tinderbox/Tb-Mozilla1.8-l10n/Linux_2.4.20-28.8_Clobber/mozilla/dist/install/thunderbird-1.4.bg.langpack.xpi
install.rdf chrome
zip I/O error: No such file or directory

zip error: Could not create output file
(/builds/tinderbox/Tb-Mozilla1.8-l10n/Linux_2.4.20-28.8_Clobber/mozilla/dist/install/thunderbird-1.4.bg.langpack.xpi)
gmake[1]: *** [langpack-bg] Error 15

I can't reproduce it on my Linux.  I "cd mail/locales" and run "make
langpack-bg" and everything is fine.  Please help me to find what's the problem,
so that it can be fixed by me.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Ognyan Kulev]

Please someone take a look at that bug - I can't reproduce it and so I (bg l10n
owner) can't handle it.

Comment 2

[Ognyan Kulev]

It seems that Linux build is OK, so I've changed OS to MacOSX.

Comment 3

[Martin Creutziger [:MMx]]

its OS X only and somehow also only occuring for "bg". 
Maybe the directory "dist/xpi-stage/locale-bg" is missing on Maya? (just an idea)

Comment 4

[Axel Hecht [:Pike]]

We need a mac buddy here, or someone with access to the tinderbox.
I have no clue what is going on here, I could suspect something line-ending wise,
but the build log doesn't even tell which file is missing.

Comment 5

[u60234]

Perhaps not relevant to this bug, but there is an error on http://lxr.mozilla.org/l10n-mozilla1.8/source/bg/other-licenses/branding/thunderbird/brand.dtd#1

<!ENTITY lang.version "__MOZILLA_LOCALE_VERSION__">

should be

#expand <!ENTITY lang.version "__MOZILLA_LOCALE_VERSION__">

eu, ga-IE, and mk also have the same error, but they don't seem to have this bug.

Comment 6

[Ognyan Kulev]

I've reported the #expand problem in http://pootlebugzilla.sjsoft.com/show_bug.cgi?id=81 .

How can I test if this is the problem?  Is committing such change the only way?  I have no access to MacOSX.

Comment 7

[Axel Hecht [:Pike]]

So, now that I have fruit, I tried this at home.

I had to mkdir dist/install, but apart from that, the build works. Before doing the mkdir, I got the exact same build error as the tinderbox.

How the freck does this only affect bg? Note that bg is in fact the first locale
to repackage, so it may be that.

Why this only happens on mac is a pure mystery to me, too.

Comment 8

[Axel Hecht [:Pike]]

Looking at 

http://lxr.mozilla.org/mozilla/source/tools/tinderbox/post-mozilla-rel.pl#783

system("mkdir -p $package_location");

is done after the build.

Comment 9

[Axel Hecht [:Pike]]

Benjamin, should the build target really rely on the tinderbox script or should
the dist/install directory be created in the build, by a dep or something?

Comment 10

[Benjamin Smedberg]

You're welcome to add a rule in the build system.

Comment 11

[Axel Hecht [:Pike]]

Attachment: create dist/install for the langpack, if it doesn't exist

Here is the patch, I'm not sure if the tinderbox scripts need a fix to handle
the existing install dir. I don't expect that though, otherwise not only the 
first build would be broken.

Comment 12

[Benjamin Smedberg]

Comment on attachment 206298 [details] [diff] [review]
create dist/install for the langpack, if it doesn't exist

You don't want $(shell), just use $(NSINSTALL) -D

Comment 13

[Axel Hecht [:Pike]]

Attachment: nsinstall it, baby

Trying just one review first.

Comment 14

[Axel Hecht [:Pike]]

Comment on attachment 206299 [details] [diff] [review]
nsinstall it, baby

I'd like to land this on both the 1.8 and 1.8.0 branches, build fix only

Comment 15

[Benjamin Smedberg]

Comment on attachment 206299 [details] [diff] [review]
nsinstall it, baby

Approved as a build-system-only change.

Comment 16

[Axel Hecht [:Pike]]

Fixed on trunk and both branches.

Comment 17

[Ognyan Kulev]

Please remove reference to this fixed bug from http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla1.8-l10n-bg

Comment 18

[Axel Hecht [:Pike]]

Done.