Closed Bug 308321 Opened 15 years ago Closed 15 years ago

Detaching attachment should remove any Content-Transfer-Encoding header

Categories

(MailNews Core :: Attachments, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: u69748, Assigned: Bienvenu)

Details

(Keywords: fixed1.8)

Attachments

(3 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 (No IDN) Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 (No IDN) Firefox/1.4

Detached message is displayed incorrectly in inline mode, if message body is empty

Reproducible: Always

Steps to Reproduce:
1.Create empty message with text attachment
2 [review].Detach attachment
3 [review].Set inline mode
4.View message

Actual Results:  
Message is displayed incorrectly

Expected Results:  
Message view shoud be empty
message 1: original empty message with text attachment
message 2: detached message
Attached image screen shot
I'm using Thunderbird 1.5 Beta 1
Reproduced with TB 1.6a1-0904, 1.5b1-0904, Win2K.  It's not dependent on the 
message body being empty.

The problem has to do with this header:
  Content-Transfer-Encoding: base64
not being removed when the new headers are written out:

Content-Type: text/plain;
 name="test.txt"
Content-Transfer-Encoding: base64    <-   TAKE THIS OUT
Content-Disposition: attachment; filename="test.txt"
X-Mozilla-External-Attachment-URL: file:///C:/test.txt
X-Mozilla-Altered: AttachmentDetached; date="Tue Sep 13 22:06:38 2005"

The C-T-E header *is* copied to the "detachment body" text showing the original 
headers.  I assume this same issue applies for quoted-printable (which will 
cause display issues with any '=' signs in the original headers).
Status: UNCONFIRMED → NEW
Component: Mail Window Front End → MailNews: Attachments
Ever confirmed: true
OS: Windows XP → All
Product: Thunderbird → Core
Hardware: PC → All
Summary: Detached message is displayed incorrectly in inline mode, if message body is empty → Detaching attachment should remove any Content-Transfer-Encoding header
Version: unspecified → Trunk
I think this should block 1.8b5 - I'll look into it.
Assignee: mscott → bienvenu
Flags: blocking1.8b5?
Attached patch proposed fixSplinter Review
don't write out transfer-encoding.
Attachment #195935 - Flags: superreview?(mscott)
this is a 1.8b5 blocker for thunderbird
Flags: blocking1.8b5? → blocking1.8b5+
Comment on attachment 195935 [details] [diff] [review]
proposed fix

david, is this code that's only fired when we are writing out a message whose
attachment has been deleted?
Attachment #195935 - Flags: superreview?(mscott)
Attachment #195935 - Flags: superreview+
Attachment #195935 - Flags: approval1.8b5+
yes, only for when attachments are detached (not even deleted, just detached)
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.