308359 - javascript cpu warning uses `ok' and `cancel' confusingly

Status: RESOLVED DUPLICATE of bug 145523

(Core :: JavaScript Engine, defect)

Description

[Ian Jackson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050513 Debian/1.7.8-1
Build Identifier: firefox 1.0.6-ubuntu13

This code in nsJSEnvironment.cpp:

  // Get the nsIPrompt interface from the docshell
  nsCOMPtr<nsIPrompt> prompt;
  ireq->GetInterface(NS_GET_IID(nsIPrompt), getter_AddRefs(prompt));
  NS_ENSURE_TRUE(prompt, JS_TRUE);

  NS_NAMED_LITERAL_STRING(title, "Script warning");
  NS_NAMED_MULTILINE_LITERAL_STRING(msg,
      NS_L("A script on this page is causing Firefox to ")
      NS_L("run slowly. If it continues to run, your ")
      NS_L("computer may become unresponsive.\n\nDo you ")
      NS_L("want to abort the script?"));

generates a dialogue box with `OK' and `cancel' as the options, where `OK' stops
the script and `cancel' lets it continue.

This is poor UI.  The buttons should be marked with what they do, for example:
  [ Stop script ]      [ Continue ]


Reproducible: Didn't try

Steps to Reproduce:
I have seen this dialogue myself - curiously, while I was searching for an
existing report of this problem.  But I do not have a recipe to reproduce it.



This bug was originally reported by an Ubuntu user, in our bugzilla:
https://bugzilla.ubuntu.com/show_bug.cgi?id=12015

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Gabriel Sjoberg: Please don't confirm bugs that are no longer bugs :).

This was fixed in bug 145523.

*** This bug has been marked as a duplicate of 145523 ***

Comment 2

[Brendan Eich [:brendan]]

(In reply to comment #1)
> Gabriel Sjoberg: Please don't confirm bugs that are no longer bugs :).
> 
> This was fixed in bug 145523.

Also: Gabriel, please don't assign bugs about dialog UI to the JavaScript Engine
component.  That component is for core ECMA-262 language implementation bugs.

/be