308382 - Need to figure out whether nsGenericElement::InsertChildAt screws up Ranges in XUL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

https://bugzilla.mozilla.org/show_bug.cgi?id=305678#c5

Comment 1

[Boris Zbarsky [:bzbarsky]]

Well, it DOES screw them up.  The only question is what, if anything, would
break if we removed that check.

If we can't think of anything obvious, I think we should just remove the check
for 1.9.

Comment 2

[[e-mail]]

I'm not sure why anyone would be mixing ranges with XUL...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Say they have a XUL editor (one for editing XUL documents).  That'd have ranges
(for selection, at least) all over.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

I checked blame, and waterson's initial RDFElement checkin had this commented out... no reason why that I can see.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 201393 [details] [diff] [review]
Proposed patch

r=me assuming you've tested that this seems to work.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Well, I ran the browser and opened and closed some windows and nothing broke...  ;)

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 201393 [details] [diff] [review]
Proposed patch

sr=jst

Comment 8

[Boris Zbarsky [:bzbarsky]]

Er... I checked this in on trunk at "2005-11-01 18:42" Pacific time.