308384 - Crash in nsPasswordManager [@ nsPasswordManager::FillPassword ]

Reporter

Description

•

19 years ago

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050912 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050912 Firefox/1.4

Firefox crashes when I use the Clear Private Data feature to clear passwords.

Happened for the first time between 1.8b4_2005082602 and 1.8b4_2005082608. 

In trunk and branch.

Reproducible: Always

Steps to Reproduce:
1. Make a new profile.
2. Put a signons.txt and key3db with passwords in it
3. Start Firefox.
4. Click Tools > Options > Privacy > Remember Passwords > Clear Private Data >
Settings and put a tick in the box "Saved Passwords" and also in "Clear Private
Data when closing Firefox".
5. Close Firefox. A confirmation dialog will appear.


Actual Results:  
After you confirm "Clear Private Data" it will crash.

TB9316848H nsPasswordManager::FillPassword 8858049d
TB9316768H
TB9316500Z
TB9316235H
TB9316077Y

TB9317944Y nsPasswordManager::FillPassword b3c9da7e	




nsPasswordManager::FillPassword 8858049d

Peter van der Woude [:Peter6]

Comment 1

•

19 years ago

http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=AviarySuiteBranchTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-08-26+01%3A00%3A00&maxdate=2005-08-26+07%3A30%3A00&cvsroot=%2Fcvsroot

TB9316848H
Stack Signature	 nsPasswordManager::FillPassword 8858049d
Product ID	Firefox15
Build ID	2005091206
Trigger Time	2005-09-13 12:20:35.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	firefox.exe + (003f3865)
URL visited	
User Comments	
Since Last Crash	71 sec
Total Uptime	8245 sec
Trigger Reason	Access violation
Source File, Line No.
c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp,
line 1908
Stack Trace 	
nsPasswordManager::FillPassword 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp,
line 1908]
nsPasswordManager::EnsureDecoderRing 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp,
line 1815]
nsPasswordManager::QueryInterface 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp,
line 205]
XPCWrappedNative::CallMethod 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,
line 2139]
XPC_WN_GetterSetter 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp,
line 1434]
js_Invoke 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c,
line 1163]
js_InternalInvoke 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c,
line 1260]
js_InternalGetOrSet 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c,
line 1303]
js_GetProperty 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsobj.c, line
2857]
js_Interpret 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c,
line 3285]
js_Invoke 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c,
line 1183]
nsXPCWrappedJSClass::CallMethod 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp,
line 1318]
nsXPCWrappedJS::CallMethod 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp,
line 462]
SharedStub 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp,
line 147]
nsEventListenerManager::HandleEvent 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/content/events/src/nsEventListenerManager.cpp,
line 1730]
nsEventListenerManager::CreateEvent 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/content/events/src/nsEventListenerManager.cpp,
line 1847]
nsXULElement::GetResource 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/content/xul/content/src/nsXULElement.cpp,
line 2305]
PresShell::AddOverrideStyleSheet 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp,
line 6545]
nsLeafBoxFrame::UpdateMouseThrough 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/xul/base/src/nsLeafBoxFrame.cpp,
line 153]
nsButtonBoxFrame::DoMouseClick 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/xul/base/src/nsButtonBoxFrame.cpp,
line 177]
PresShell::IsVisible 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp,
line 6489]
PresShell::HandleEventInternal 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp,
line 6347]
nsEventStateManager::ChangeFocusWith 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/content/events/src/nsEventStateManager.cpp,
line 3101]
nsEventStateManager::PostHandleEvent 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/content/events/src/nsEventStateManager.cpp,
line 2035]
PresShell::GetAgentStyleSheets 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp,
line 6525]
PresShell::HandleEvent 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp,
line 6076]
nsViewManager::InsertZPlaceholder 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/view/src/nsViewManager.cpp,
line 2785]
nsViewManager::ReparentViews 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/view/src/nsViewManager.cpp,
line 2304]
nsIView::GetScreenPosition 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/view/src/nsView.cpp,
line 844]
nsWindow::DispatchAppCommandEvent 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1310]
nsWindow::DispatchMouseEvent 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 6056]
nsWindow::SetIcon 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 6274]
nsWindow::StandardWindowCreate 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp,
line 1513]
USER32.dll + 0x8709 (0x77d18709)
USER32.dll + 0x87eb (0x77d187eb)
USER32.dll + 0x89a5 (0x77d189a5)
USER32.dll + 0x89e8 (0x77d189e8)
DetectWindowMove 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsToolkit.cpp,
line 168]
nsContentTreeOwner::GetTitle 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/xpfe/appshell/src/nsContentTreeOwner.cpp,
line 571]
nsWindowWatcher::OpenWindowJS 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp,
line 603]
XPTC_InvokeByIndex 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp,
line 102]
XPCWrappedNative::CallMethod 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,
line 2139]
XPC_WN_CallMethod 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp,
line 1402]
js_Invoke 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c,
line 1163]
js_Interpret 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c,
line 3459]
js_Invoke 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c,
line 1183]
nsXPCWrappedJSClass::CallMethod 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp,
line 1318]
nsXPCWrappedJS::CallMethod 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp,
line 462]
SharedStub 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp,
line 147]
nsObserverService::NotifyObservers 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/xpcom/ds/nsObserverService.cpp,
line 235]
nsXREDirProvider::DoShutdown 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/toolkit/xre/nsXREDirProvider.cpp,
line 637]
ScopedXPCOMStartup::~ScopedXPCOMStartup 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/toolkit/xre/nsAppRunner.cpp,
line 567]
main 
[c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/browser/app/nsBrowserApp.cpp,
line 61]
kernel32.dll + 0x16d4f (0x7c816d4f)

Summary: Crash in nsPasswordManager → Crash in nsPasswordManager [@ nsPasswordManager::FillPassword ]

Ria Klaassen (not reading all bugmail)

Reporter

Updated

•

19 years ago

Keywords: regression

Version: unspecified → 1.5 Branch

Ria Klaassen (not reading all bugmail)

Reporter

Updated

•

19 years ago

Flags: blocking1.8b5?

Asa Dotzler [:asa]

Comment 2

•

19 years ago

I a few crashes around this stack showing up in topcrash data. we have a good
regression window and a not-uncommon crasher in a new feature here. Let's get on
top of this for 1.5 b2

Assignee: nobody → bugs.mano

Status: UNCONFIRMED → NEW

Ever confirmed: true

Flags: blocking1.8b5? → blocking1.8b5+

Asaf Romano (gone)

Updated

•

19 years ago

Assignee: bugs.mano → g.maone

Blocks: 284086

Giorgio Maone [:ma1]

Assignee

Comment 3

•

19 years ago

Attached patch Move BrowserGlue shutdown tasks from "profile-before-change" to "profile-change-teardown" — Details — Splinter Review

I'm fixing the caller rather than the password manager, because this simple
patch should settle down also bug 307840 and the reported regressions from bug
284086.
I'm anticipating UI shutdown tasks in "profile-change-teardown", so we are sure
we still find other components in a consistent state.

Giorgio Maone [:ma1]

Assignee

Updated

•

19 years ago

Attachment #196536 - Flags: review?(mconnor)

Mike Connor [:mconnor]

Updated

•

19 years ago

Attachment #196536 - Flags: review?(mconnor) → review+

Giorgio Maone [:ma1]

Assignee

Updated

•

19 years ago

Blocks: 309031

Giorgio Maone [:ma1]

Assignee

Updated

•

19 years ago

Attachment #196536 - Flags: approval1.8b5?

:Gavin Sharp [email: gavin@gavinsharp.com]

Updated

•

19 years ago

Whiteboard: [checkin needed]

Asaf Romano (gone)

Comment 4

•

19 years ago

Checking in browser/components/nsBrowserGlue.js;
/cvsroot/mozilla/browser/components/nsBrowserGlue.js,v  <--  nsBrowserGlue.js
new revision: 1.5; previous revision: 1.4
done

Status: NEW → RESOLVED

Closed: 19 years ago

Resolution: --- → FIXED

:Gavin Sharp [email: gavin@gavinsharp.com]

Updated

•

19 years ago

Blocks: 307840, 308940
No longer blocks: 284086

:Gavin Sharp [email: gavin@gavinsharp.com]

Updated

•

19 years ago

Whiteboard: [checkin needed]

Mike Schroepfer

Comment 5

•

19 years ago

Comment on attachment 196536 [details] [diff] [review]
Move BrowserGlue shutdown tasks from "profile-before-change" to "profile-change-teardown"

Approved for 1.8b5 per bug meeting

Attachment #196536 - Flags: approval1.8b5? → approval1.8b5+

Asaf Romano (gone)

Comment 6

•

19 years ago

1.8 Branch:
Checking in nsBrowserGlue.js;
/cvsroot/mozilla/browser/components/nsBrowserGlue.js,v  <--  nsBrowserGlue.js
new revision: 1.4.2.5; previous revision: 1.4.2.4
done

Keywords: fixed1.8

Josh Aas

Comment 7

•

19 years ago

*** Bug 308940 has been marked as a duplicate of this bug. ***

Ryan Flint [:rflint] (ping via IRC for reviews)

Comment 8

•

19 years ago

*** Bug 310203 has been marked as a duplicate of this bug. ***

Greg K.

Updated

•

19 years ago

Severity: normal → critical

Keywords: crash

Tracy Walker [:tracy]

Updated

•

19 years ago

Keywords: fixed1.8 → verified1.8

Nobody; OK to take it and work on it

Updated

•

16 years ago

Product: Firefox → Toolkit

Nobody; OK to take it and work on it

Updated

•

13 years ago

Crash Signature: [@ nsPasswordManager::FillPassword ]