Closed Bug 308387 Opened 19 years ago Closed 19 years ago

Please unfork nsNativeThemeGTK.cpp

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: darin.moz, Assigned: blizzard)

Details

Please unfork nsNativeThemeGTK.cpp

The fix for bug 305291 forked nsNativeThemeGTK.cpp, but the two files are
exactly the same.  Bryner says that there is no reason to fork this file, and
that it was intended to be shared between the two GTK versions.  I'd be nice to
unfork it.  Perhaps it could live in widget/src/gtk only, and then have the gtk2
build reach into the gtk directory for this source file.
They're the same for now, but the gtk2 version will be getting heavily modified
in the near future; I'd rather not un-fork them now just to fork them again later.
OK, so then you want to mark this WONTFIX?
Sure, I just hate to mark things WONTFIX ;)  btw, the reason for the forking is
that there will be goop in there for cairo surface management and probably stuff
for offscreen rendering/compositing for glitz, for native theme'd widgets.. that
stuff will probably never work on gtk1, though it's possible.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WONTFIX
Is there any compelling reason to support GTK1 for 1.9?
I don't think so; gtk1 is in theory faster currently, but we can cross some
fingers and hope that cairo-ized gtk2 will be faster. Maybe. Hopefully.
You need to log in before you can comment on or make changes to this bug.