308418 - windbgdlg pops up even when mozilla is in the debugger

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

jst and I noticed not too long ago that the windbgdlg pop up was coming up, even
when we were already running in the debugger (MSVC). This is pretty annoying,
since it means that there is now an extra click per assertion.

This appears to be a regression from bug 304237. The test for
shouldIgnoreDebugger (and the related strcmp) is partially reversed. I'll attach
a patch which gives the behavior that if the enviornment variable doesn't exist
or it is not set to "1", then we look up if we are already debugging.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: deflip the logic

This is the intended logic (opt-out through no action).

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Note that the patch is diff -w, since I reindented the block to fit with the
surrounding code.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 196000 [details] [diff] [review]
deflip the logic

white space looks off.

Comment 4

[Doug Turner (:dougt)]

didn't read your comment about the white space (diff -w). :-)

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Checked in on trunk. I don't think this needs to go in on branch, unless someone
really wants it.