308490 - Improve CSS/XBL for horizontally scrolling trees

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[[e-mail]]

Comment 1

[[e-mail]]

Attachment: Proposed patch

I also moved the scrollcorner width in to the theme (Modern is only 15px).

Comment 2

[Jan Varga [:janv]]

Neil, I'll take a look at the patch

Comment 3

[Jan Varga [:janv]]

Neil, where is hidehscroll and hidevscroll defined?
Shouldn't you update toolkit/themes too?

Comment 4

[Martijn Wargers (dead)]

I was thinking, aren't hidehscroll and hidevscroll a bit odd names? Maybe
something in line with the css properties overflow-x and overflow-y is more
appropriate?

Comment 5

[Erik Arvidsson]

I agree with Martijn here. Why isn't this controlled by the CSS overflow properties?

Comment 6

[[e-mail]]

(In reply to comment #3)
>Neil, where is hidehscroll and hidevscroll defined?
They're simply arbitrary names. They get converted to collapsed by the XBL.
>Shouldn't you update toolkit/themes too?
Sure, once I get an xpfe patch that you like ;-)

(In reply to comment #5)
>Why isn't this controlled by the CSS overflow properties?
Because we're not using a scroll frame.

Comment 7

[[e-mail]]

Attachment: Complete patch

Comment 8

[Jan Varga [:janv]]

Comment on attachment 198987 [details] [diff] [review]
Complete patch

nice cleanup, r=varga

Comment 9

[[e-mail]]

Fix checked in.

Comment 10

[Martijn Wargers (dead)]

Ah, now I see, hidehscroll and hidevscroll are only used internally, xul authors don't need to tinker with it.