308501 - nsIFile.create failure when an extension is removed from a location w/o write access

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

When running a build without talkback and a profile that had talkback installed
from an earlier build. This was on Linux but I can't imagine that it wouldn't
affect other OS's where the user only had read access. This has been around a
while and I have just now been able to duplicate.

Error: [Exception... "Component returned failure code: 0x80520015
(NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]"  nsresult: "0x80520015
(NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame ::
file:///usr/local/firefox/components/nsExtensionManager.js :: anonymous :: line
1051"  data: no]
Source File: file:///usr/local/firefox/components/nsExtensionManager.js
Line: 1051

I'll try to get to this tonight.

Comment 1

[Robert Strong (they/them - no direct email)]

Note: talkback does not uninstall as it should in this instance.

Comment 2

[Benjamin Smedberg]

Hrm... if the files disappeared we really shouldn't be "uninstalling" the
extension, we should just remove the extension information from the RDF.

Comment 3

[Robert Strong (they/them - no direct email)]

Of course... I was using the term uninstall in regards to the process (e.g. in
this instance it should remove all references to the extension which is a part
of the overall uninstall process).

Ya' know, I've seen this before when the EM rewrite landed and I just never
found the time to consider the ramifications... doh!

Comment 4

[Robert Strong (they/them - no direct email)]

Fixed on trunk - patch is included in the patch for bug 307566

Comment 5

[Robert Strong (they/them - no direct email)]

Also fixed1.8 by the branch checkin for bug 307566