Closed Bug 308511 Opened 16 years ago Closed 16 years ago

nsILDAPBERElements are incorrectly encoded

Categories

(Directory :: LDAP XPCOM SDK, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dmose, Assigned: dmose)

Details

(Keywords: fixed1.8)

Attachments

(1 file)

4 byte long length fields are being generated because we're calling ber_alloc()
instead of ber_alloc_t(LBER_USE_DER).  Discovered by careful perusal of the
source and
<http://www.mozilla.org/directory/ietf-docs/draft-ietf-ldapext-ldap-c-api-05.txt>.
 Patch forthcoming.
Attachment #196049 - Flags: superreview?(bienvenu)
Attachment #196049 - Flags: review?(bienvenu)
Attachment #196049 - Flags: superreview?(bienvenu)
Attachment #196049 - Flags: superreview+
Attachment #196049 - Flags: review?(bienvenu)
Attachment #196049 - Flags: review+
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Without this fix, LDAP controls generated by the nsILDAPControl code a while ago
are invalid.  Fortunately, the fix is essentially zero risk, since noone yet
depends on these interfaces except for a single customer extension for
Thunderbird  that Ive done some work on.
Flags: blocking1.8b5?
Flags: blocking1.8b5? → blocking1.8b5+
Comment on attachment 196049 [details] [diff] [review]
change allocation code, v1

approving for the branch. Thanks Dan.
Attachment #196049 - Flags: approval1.8b5+
Checked in on the branch.
Flags: blocking1.8b5+
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.