Last Comment Bug 308511 - nsILDAPBERElements are incorrectly encoded
: nsILDAPBERElements are incorrectly encoded
: fixed1.8
Product: Directory
Classification: Components
Component: LDAP XPCOM SDK (show other bugs)
: other
: All All
-- normal (vote)
: ---
Assigned To: Dan Mosedale (:dmose)
Depends on:
  Show dependency treegraph
Reported: 2005-09-14 10:02 PDT by Dan Mosedale (:dmose)
Modified: 2005-09-16 12:14 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

change allocation code, v1 (575 bytes, patch)
2005-09-14 10:04 PDT, Dan Mosedale (:dmose)
mozilla: review+
mozilla: superreview+
mscott: approval1.8b5+
Details | Diff | Splinter Review

Description User image Dan Mosedale (:dmose) 2005-09-14 10:02:37 PDT
4 byte long length fields are being generated because we're calling ber_alloc()
instead of ber_alloc_t(LBER_USE_DER).  Discovered by careful perusal of the
source and
 Patch forthcoming.
Comment 1 User image Dan Mosedale (:dmose) 2005-09-14 10:04:21 PDT
Created attachment 196049 [details] [diff] [review]
change allocation code, v1
Comment 2 User image Dan Mosedale (:dmose) 2005-09-14 16:08:49 PDT
Without this fix, LDAP controls generated by the nsILDAPControl code a while ago
are invalid.  Fortunately, the fix is essentially zero risk, since noone yet
depends on these interfaces except for a single customer extension for
Thunderbird  that Ive done some work on.
Comment 3 User image Scott MacGregor 2005-09-14 23:18:55 PDT
Comment on attachment 196049 [details] [diff] [review]
change allocation code, v1

approving for the branch. Thanks Dan.
Comment 4 User image Dan Mosedale (:dmose) 2005-09-15 08:50:21 PDT
Checked in on the branch.

Note You need to log in before you can comment on or make changes to this bug.