308535 - shortcut keys in menus are left-aligned instead of right aligned.

Status: RESOLVED WORKSFORME

(Toolkit :: Themes, defect)

Description

[Pascal Chevrel (relman team) -> :pascalc]

Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8b4) Gecko/20050910 (No IDN)
Firefox/1.4

All shortcuts in menus are left aligned while on windows (XP/Luna at least),
shortcuts are always right-aligned.

I don't really care about it but apparently there has been some focus recently
on making Firefox looking more integrated into the OS. Same problem for Thundebird.

Comment 1

[Pascal Chevrel (relman team) -> :pascalc]

Attachment: screenshot of the problem

here is a screenshot of the problem, on the left Adobre photoshop, on the right
Firefox. All the windows applications I know have their shortcuts right-aligned

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Bug 27349 is WONTFIX, but bug 88212 and bug bug 38462 were duped to bug 38367,
and it's marked fixed. I'm confused :)

Comment 3

[Mike Connor [:mconnor]]

bug 38367 actually created the current setup whereby they're left-aligned in a
second column.  Making them right-aligned actually looks a little sloppy because
you end up with the following options in the File menu, all ever so slightly
smaller than the previous item.  

Ctrl+N
Ctrl+T
Ctrl+L

Just to be sure though, I tested it looks like we're pretty much right on
Windows for true native menus.

Tested Windows:
Right-aligned: IE, TextPad, Notepad, Outlook Express (native menus)
Left-aligned: Outlook 2003 (non-native menus)

Mac/GNOME is a different story, it seems, but at least on Windows this is
correct and shouldn't change.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

On Mac, the shortcuts are displayed in menus with the command-icon center
aligned, and icons for modifier keys (shift, alt) to the left and the letter-key
to the right.

Firefox seems to play along with rather nicely.

Comment 5

[Wayne Mery (:wsmwk)]

And Linux?


xref Bug 402117 – menu shortcuts are right aligned when opening menu first time

Comment 6

[Nikhil Johny]

hi, i am a noob so how can i get started in fixing this bug

Comment 7

[Dão Gottwald [:dao]]

(In reply to Mike Connor [:mconnor] from comment #3)
> bug 38367 actually created the current setup whereby they're left-aligned in
> a
> second column.  Making them right-aligned actually looks a little sloppy
> because
> you end up with the following options in the File menu, all ever so slightly
> smaller than the previous item.  
> 
> Ctrl+N
> Ctrl+T
> Ctrl+L
> 
> Just to be sure though, I tested it looks like we're pretty much right on
> Windows for true native menus.
> 
> Tested Windows:
> Right-aligned: IE, TextPad, Notepad, Outlook Express (native menus)
> Left-aligned: Outlook 2003 (non-native menus)

So Firefox actually does *not* behave like IE, Notepad et al.

Comment 8

[Dão Gottwald [:dao]]

(In reply to Nikhil Johny from comment #6)
> hi, i am a noob so how can i get started in fixing this bug

I believe this can be fixed by adding this to toolkit/themes/winstripe/global/menu.css:

.menu-accel-container {
  -moz-box-pack: end;
}

Comment 9

[Nikhil Johny]

(In reply to Dão Gottwald [:dao] from comment #8)
> (In reply to Nikhil Johny from comment #6)
> > hi, i am a noob so how can i get started in fixing this bug
> 
> I believe this can be fixed by adding this to
> toolkit/themes/winstripe/global/menu.css:
> 
> .menu-accel-container {
>   -moz-box-pack: end;
> }

thank you for the reply. i did add the code in the menu.css, how can i check if it works for myself. another problem is that i didn't understand how the code works. is there a documentation that i can refer to?

Comment 10

[Dão Gottwald [:dao]]

Nikhil, please see <https://developer.mozilla.org/en-US/docs/Introduction>.