some configure.in cleanup

RESOLVED FIXED

Status

Firefox Build System
General
RESOLVED FIXED
13 years ago
4 months ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

Trunk
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
 
(Assignee)

Comment 1

13 years ago
Created attachment 196096 [details] [diff] [review]
patch v.1

1) Not all MOZ_XUL_APPS need or want updater.  This patch fixes this.
2) Disables View Source in minimo.
3) Removes data: protocol from minimo.
4) Removes XFT from minimo.
(Assignee)

Comment 2

13 years ago
Comment on attachment 196096 [details] [diff] [review]
patch v.1

there is an extra '=' char in the patch:

-  NECKO_PROTOCOLS="about,data,http,file,res,jar"
+  NECKO_PROTOCOLS_DEFAULT=="about,http,file,res,jar"

i have removed it.
Comment on attachment 196096 [details] [diff] [review]
patch v.1

>-  NECKO_PROTOCOLS="about,data,http,file,res,jar"
>+  NECKO_PROTOCOLS_DEFAULT=="about,http,file,res,jar"

I think you should keep data.  It's small and useful, and we may want to
encourage its use on mobile devices.

And you certainly want == rather than =.

Other than that this looks fine.
Attachment #196096 - Flags: review+
Er, = rather than ==.
(Assignee)

Comment 5

13 years ago
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1528; previous revision: 1.1527
done


I didn't change the data: per dbaron's request.  Also, i am using space
delimiters in the default protcols like how it is today.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.