Closed Bug 308591 Opened 18 years ago Closed 18 years ago

Button.dlgType sets an attribute with the wrong case

Categories

(Toolkit :: XUL Widgets, defect)

Product:
Toolkit
Component:
XUL Widgets
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1

People

(Reporter: enndeakin, Assigned: enndeakin)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

change case of dlgType
2.39 KB, patch
neil
: first-review+
mconnor
: approval-branch-1.8.1+
Details | Diff | Splinter Review 
Button's dlgType property is setting the attribute with the uppercase T but the
dialog uses lowercase dlgtype.

        Attachment #196110 -
        Flags: first-review?(neil.parkwaycc.co.uk)

    
    

    
  
Comment on attachment 196110 [details] [diff] [review]
change case of dlgType

r+sr=me

    
  

        Attachment #196110 -
        Flags: first-review?(neil.parkwaycc.co.uk) → first-review+

    
    

    
  
This was never checked in... Neil?
(Also, this means that the dlgType property never worked, right?)

    
    

    
  
Enn said that "it can be checked in if the reviews are ok" on IRC.
Whiteboard: [checkin needed]

    
    

    
  
I checked it in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]

        Attachment #196110 -
        Flags: branch-1.8.1?(mconnor)

        Attachment #196110 -
        Flags: branch-1.8.1?(mconnor) → branch-1.8.1+

    
    

    
  
Checked in on the 1.8 branch.
mozilla/toolkit/content/widgets/button.xml; new revision: 1.12.4.1;
mozilla/xpfe/global/resources/content/bindings/button.xml; new revision: 1.27.4.1;
Keywords: fixed1.8.1
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8.1

          You need to log in
          before you can comment on or make changes to this bug.