Closed
Bug 308591
Opened 19 years ago
Closed 19 years ago
Button.dlgType sets an attribute with the wrong case
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: enndeakin, Assigned: enndeakin)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
2.39 KB,
patch
|
neil
:
first-review+
mconnor
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
Button's dlgType property is setting the attribute with the uppercase T but the
dialog uses lowercase dlgtype.
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #196110 -
Flags: first-review?(neil.parkwaycc.co.uk)
Comment 2•19 years ago
|
||
Comment on attachment 196110 [details] [diff] [review]
change case of dlgType
r+sr=me
Updated•19 years ago
|
Attachment #196110 -
Flags: first-review?(neil.parkwaycc.co.uk) → first-review+
Comment 3•19 years ago
|
||
This was never checked in... Neil?
(Also, this means that the dlgType property never worked, right?)
Comment 4•19 years ago
|
||
Enn said that "it can be checked in if the reviews are ok" on IRC.
Whiteboard: [checkin needed]
Assignee | ||
Comment 5•19 years ago
|
||
I checked it in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Updated•19 years ago
|
Attachment #196110 -
Flags: branch-1.8.1?(mconnor)
Updated•19 years ago
|
Attachment #196110 -
Flags: branch-1.8.1?(mconnor) → branch-1.8.1+
Comment 6•19 years ago
|
||
Checked in on the 1.8 branch.
mozilla/toolkit/content/widgets/button.xml; new revision: 1.12.4.1;
mozilla/xpfe/global/resources/content/bindings/button.xml; new revision: 1.27.4.1;
You need to log in
before you can comment on or make changes to this bug.
Description
•