Last Comment Bug 308591 - Button.dlgType sets an attribute with the wrong case
: Button.dlgType sets an attribute with the wrong case
Status: RESOLVED FIXED
: fixed1.8.1
Product: Toolkit
Classification: Components
Component: XUL Widgets (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla1.8.1
Assigned To: Neil Deakin
:
: Neil Deakin
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-09-14 19:16 PDT by Neil Deakin
Modified: 2006-02-01 11:06 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
change case of dlgType (2.39 KB, patch)
2005-09-14 19:21 PDT, Neil Deakin
neil: first‑review+
mconnor: approval‑branch‑1.8.1+
Details | Diff | Splinter Review

Description Neil Deakin 2005-09-14 19:16:11 PDT
Button's dlgType property is setting the attribute with the uppercase T but the
dialog uses lowercase dlgtype.
Comment 1 Neil Deakin 2005-09-14 19:21:04 PDT
Created attachment 196110 [details] [diff] [review]
change case of dlgType
Comment 2 neil@parkwaycc.co.uk 2005-09-19 05:41:35 PDT
Comment on attachment 196110 [details] [diff] [review]
change case of dlgType

r+sr=me
Comment 3 :Gavin Sharp [email: gavin@gavinsharp.com] 2005-11-25 13:11:35 PST
This was never checked in... Neil?
(Also, this means that the dlgType property never worked, right?)
Comment 4 Nickolay_Ponomarev 2006-01-15 14:17:57 PST
Enn said that "it can be checked in if the reviews are ok" on IRC.
Comment 5 Neil Deakin 2006-01-15 14:25:46 PST
I checked it in.
Comment 6 :Gavin Sharp [email: gavin@gavinsharp.com] 2006-02-01 11:06:46 PST
Checked in on the 1.8 branch.
mozilla/toolkit/content/widgets/button.xml; new revision: 1.12.4.1;
mozilla/xpfe/global/resources/content/bindings/button.xml; new revision: 1.27.4.1;

Note You need to log in before you can comment on or make changes to this bug.