Button.dlgType sets an attribute with the wrong case

RESOLVED FIXED in mozilla1.8.1

Status

()

Toolkit
XUL Widgets
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Neil Deakin (not available until Aug 9), Assigned: Neil Deakin (not available until Aug 9))

Tracking

({fixed1.8.1})

unspecified
mozilla1.8.1
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Button's dlgType property is setting the attribute with the uppercase T but the
dialog uses lowercase dlgtype.
Created attachment 196110 [details] [diff] [review]
change case of dlgType
Attachment #196110 - Flags: first-review?(neil.parkwaycc.co.uk)

Comment 2

12 years ago
Comment on attachment 196110 [details] [diff] [review]
change case of dlgType

r+sr=me

Updated

12 years ago
Attachment #196110 - Flags: first-review?(neil.parkwaycc.co.uk) → first-review+
This was never checked in... Neil?
(Also, this means that the dlgType property never worked, right?)

Comment 4

12 years ago
Enn said that "it can be checked in if the reviews are ok" on IRC.
Whiteboard: [checkin needed]
I checked it in.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Attachment #196110 - Flags: branch-1.8.1?(mconnor)

Updated

12 years ago
Attachment #196110 - Flags: branch-1.8.1?(mconnor) → branch-1.8.1+
Checked in on the 1.8 branch.
mozilla/toolkit/content/widgets/button.xml; new revision: 1.12.4.1;
mozilla/xpfe/global/resources/content/bindings/button.xml; new revision: 1.27.4.1;
Keywords: fixed1.8.1
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8.1
You need to log in before you can comment on or make changes to this bug.