308653 - [PostgreSQL] 'relation "map_products" does not exist' when the classification column is displayed

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Frédéric Buclin]

DBD::Pg::st execute failed: ERROR:  relation "map_products" does not exist
[for Statement "SELECT ... FROM bugs  ... INNER JOIN classifications AS
map_classifications ON (map_products.classification_id = map_classifications.id)
INNER JOIN products AS map_products ON (bugs.product_id = map_products.id) ...
"] at /var/www/html/bugzilla-tip-pg/buglist.cgi line 834

It looks like that MySQL doesn't care about the order in which tables are
joined, but PostgreSQL does, and when "ON (map_products.classification_id =
map_classifications.id)" is called, "INNER JOIN products AS map_products" has
not been declared yet.


This incorrect order comes from bug 286461:

Search.pm, line 141:

    if (lsearch($fieldsref, 'map_classifications.name') >= 0) {
        push @supptables,
                "INNER JOIN classifications AS map_classifications " .
                "ON map_products.classification_id = map_classifications.id";
        push @supptables, "INNER JOIN products AS map_products " .
                          "ON bugs.product_id = map_products.id";
    }

These insertions should be inverted.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Applies on both tip and 2.20

Comment 2

[Max Kanat-Alexander]

Comment on attachment 196145 [details] [diff] [review]
patch, v1

r=mkanat by inspection. :-) Obviously correct. :-)

Comment 3

[Frédéric Buclin]

tip:

Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.113; previous revision: 1.112
done

2.20rc2:

Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.99.2.5; previous revision: 1.99.2.4
done