308666 - Getting a popup error message when checking dependencies

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Paul]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; T312461; PPG; .NET CLR 1.1.4322)
Build Identifier: Bugzilla Version 2.18.3 

I set some dependencies for a bug, then pressed "Show Dependencies Tree"
I get an error that says:
A runtime error has occured.
Do you wish to debug?
Line 313
Error: expected identifier, string or number.

I set the URL on bugzilla.org because it's happening there too.

Reproducible: Always

Steps to Reproduce:

Actual Results:  
popup error message

Expected Results:  
No error please.

Comment 1

[Frédéric Buclin]

The URL WFM using Fx 1.0.6 on Linux

Comment 2

[Paul]

Happens on:
Internet Explorer 6.0.2800.1106CO
OS Windows 2000

Comment 3

[Max Kanat-Alexander]

This may be a dup, I recall hearing about this before.

Comment 4

[:glob ✱]

confirming.

the line that's causing the problem is where we define var Node ..

if (!Node) {
    /* MSIE doesn't define Node, so provide a compatibility array */
    var Node = { TEXT_NODE: 3, };
}

the fix is to remove the trailing ,

if (!Node) {
    /* MSIE doesn't define Node, so provide a compatibility array */
    var Node = { TEXT_NODE: 3 };
}

also of interest is the <script> block is after </html>

Comment 5

[Frédéric Buclin]

glob, could you fix this bug?

Comment 6

[:glob ✱]

Attachment: v1

removes trailing comma that causes IE warning.

Comment 7

[Teemu Mannermaa (:wicked)]

Looks like the JavaScript introduced in bug 236424 has never worked on IE. That
bug is targeted to 2.18 so only 2.16 branch is not affected by this.

And yes, that JS script is located after </html> AND it messed up
depthControlToolbar BLOCKs comment too. Not good.

Comment 8

[Teemu Mannermaa (:wicked)]

Comment on attachment 197499 [details] [diff] [review]
v1

So this seems to fix the original popup. But when toggling is actually
attempted a new popup hits:

Line: 333
Char: 5
Error: 'nodeType' is null or not an object

Comment 9

[Paul]

Looks like Mac is having the same trouble.  Bug# 309106

Comment 10

[:glob ✱]

*** Bug 309106 has been marked as a duplicate of this bug. ***

Comment 11

[:glob ✱]

Attachment: v2 (2.20 branch and tip)

uses event.srcElement if event.target doesn't exist
moves the javascript before </html>
moves block toolbar comment to correct location

this works on firefox and ie, can someone please test with safari.

Comment 12

[Teemu Mannermaa (:wicked)]

Comment on attachment 197642 [details] [diff] [review]
v2 (2.20 branch and tip)

Tested to fix all mentioned problems on 2.20 branch and on tip using Firefox,
IE 6 and Opera 7.

Can't test Safari, so requesting additional review for that.

Also, second hunk doesn't apply cleanly on 2.18 branch so a backport is needed
if a fix for 2.18 is wanted.

Comment 13

[:glob ✱]

*** Bug 254942 has been marked as a duplicate of this bug. ***

Comment 14

[Frédéric Buclin]

Let's take it for 2.20 and tip only and let's ask justdave to test it on Safari as he is using Mac. justdave, could you please do a quick test on Safari and grant approval? No need to delay this fix any longer.

Comment 15

[Dave Miller [:justdave]]

(In reply to comment #14)
> Let's take it for 2.20 and tip only and let's ask justdave to test it on Safari
> as he is using Mac. justdave, could you please do a quick test on Safari and
> grant approval? No need to delay this fix any longer.

no error, but it doesn't work, either, in Safari, before patching.  After the patch, it works in Safari, and it still works in Firefox.

Comment 16

[Frédéric Buclin]

tip:

Checking in template/en/default/bug/dependency-tree.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-tree.html.tmpl,v  <--  dependency-tree.html.tmpl
new revision: 1.17; previous revision: 1.16
done

2.20:

Checking in template/en/default/bug/dependency-tree.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-tree.html.tmpl,v  <--  dependency-tree.html.tmpl
new revision: 1.15.4.1; previous revision: 1.15
done