If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

use langpack-$(AB_CD)@firefox.mozilla.org for MOZ_LANGPACK_EID

VERIFIED FIXED

Status

()

Firefox
Build Config
VERIFIED FIXED
12 years ago
10 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

({fixed1.8, late-l10n})

1.5.0.x Branch
fixed1.8, late-l10n
Points:
---
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

12 years ago
We currently use uuids for the langpack extension IDs, which requires an extra
step in QA to check that none of those are copy-and-pasted by l10n.
As we support foo@bar.tld now, let's make this easier.

This does have l10n impact, but it only requires a removal of 1 line in each
/l10n/$ab-CD$/$product$/defines.inc.

Patch coming up, if we want this, I'll file a corresponding bug for thunderbird,
too.
(Assignee)

Comment 1

12 years ago
Created attachment 196164 [details] [diff] [review]
move MOZ_LANGPACK_EID from defines.inc to Makefile.in
Attachment #196164 - Flags: review?(benjamin)
(Assignee)

Comment 2

12 years ago
Created attachment 196165 [details]
install.rdf after with this patch, coming from dist/xpi-stage/locale-en-US

To make reviewing a bit easier, I tested this with 
make langpack-en-US
in browser/locales and attach the resulting install.rdf.
(Assignee)

Comment 3

12 years ago
Just link-dropping http://lxr.mozilla.org/seamonkey/search?string=MOZ_LANGPACK_EID
to show that this is complete and low risk. 

Updated

12 years ago
Attachment #196164 - Flags: review?(benjamin) → review+
(Assignee)

Comment 4

12 years ago
Heads up notice to localizers. If we land this, I will take the freedom/do the
service to remove the langpack IDs from your localizations, so there shouldn't
be anything to do for you, and all builds should stay happy.

Updated

12 years ago
Attachment #196164 - Flags: superreview+
(Assignee)

Comment 5

12 years ago
Created attachment 196175 [details] [diff] [review]
removing MOZ_LANGPACK_EID from all locales in CVS

Here the patch to remove the LANGPACK EIDs from the locales in CVS, for
reference.
(Assignee)

Comment 6

12 years ago
mac is green on the trunk, going to verify the xpis tomorrow.

Putting this on the radar of drivers, I'll request approval on the patch tomorrow
after verification. As for the trunk, I will cover the l10n impact on the branch,
too.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Flags: blocking1.8b5?
Keywords: late-l10n
Resolution: --- → FIXED

Updated

12 years ago
Flags: blocking1.8b5? → blocking1.8b5+
(Assignee)

Comment 7

12 years ago
VERIFIED.

To those looking at this bug, I'm working on bug 307225, too, fixing langpacks
a bit more.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 8

12 years ago
Comment on attachment 196164 [details] [diff] [review]
move MOZ_LANGPACK_EID from defines.inc to Makefile.in

requesting to land this on the branch.

I filed bug 308827 for this change on thunderbird.
Attachment #196164 - Flags: approval1.8b5?

Updated

12 years ago
Attachment #196164 - Flags: approval1.8b5? → approval1.8b5+
(Assignee)

Comment 9

12 years ago
FIXED on the 1.8 branch, too.
Keywords: fixed1.8

Updated

10 years ago
Blocks: 299269
You need to log in before you can comment on or make changes to this bug.