308672 - use langpack-$(AB_CD)@firefox.mozilla.org for MOZ_LANGPACK_EID

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Axel Hecht [:Pike]]

We currently use uuids for the langpack extension IDs, which requires an extra
step in QA to check that none of those are copy-and-pasted by l10n.
As we support [e-mail] now, let's make this easier.

This does have l10n impact, but it only requires a removal of 1 line in each
/l10n/$ab-CD$/$product$/defines.inc.

Patch coming up, if we want this, I'll file a corresponding bug for thunderbird,
too.

Comment 1

[Axel Hecht [:Pike]]

Attachment: move MOZ_LANGPACK_EID from defines.inc to Makefile.in

Comment 2

[Axel Hecht [:Pike]]

Attachment: install.rdf after with this patch, coming from dist/xpi-stage/locale-en-US

To make reviewing a bit easier, I tested this with 
make langpack-en-US
in browser/locales and attach the resulting install.rdf.

Comment 3

[Axel Hecht [:Pike]]

Just link-dropping http://lxr.mozilla.org/seamonkey/search?string=MOZ_LANGPACK_EID
to show that this is complete and low risk. 

Comment 4

[Axel Hecht [:Pike]]

Heads up notice to localizers. If we land this, I will take the freedom/do the
service to remove the langpack IDs from your localizations, so there shouldn't
be anything to do for you, and all builds should stay happy.

Comment 5

[Axel Hecht [:Pike]]

Attachment: removing MOZ_LANGPACK_EID from all locales in CVS

Here the patch to remove the LANGPACK EIDs from the locales in CVS, for
reference.

Comment 6

[Axel Hecht [:Pike]]

mac is green on the trunk, going to verify the xpis tomorrow.

Putting this on the radar of drivers, I'll request approval on the patch tomorrow
after verification. As for the trunk, I will cover the l10n impact on the branch,
too.

Comment 7

[Axel Hecht [:Pike]]

VERIFIED.

To those looking at this bug, I'm working on bug 307225, too, fixing langpacks
a bit more.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 196164 [details] [diff] [review]
move MOZ_LANGPACK_EID from defines.inc to Makefile.in

requesting to land this on the branch.

I filed bug 308827 for this change on thunderbird.

Comment 9

[Axel Hecht [:Pike]]

FIXED on the 1.8 branch, too.