The default bug view has changed. See this FAQ.

Limit the values we accept for currentScale

RESOLVED FIXED

Status

()

Core
SVG
--
critical
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

({fixed1.8, hang})

Trunk
fixed1.8, hang
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
We need to put limits on the values we allow for currentScale. Playing with

http://jwatt.org/svg/tests/zoom-and-pan-controls.svg

shows that you don't have to zoom in or out too many times before nasty
artifacts and maxing out of CPU and memory occurs. ASV allows for a maximum
value of 16 and a minimum value of 0.0625. Unless anyone has other ideas, I
suggest we use these limits too.
(Assignee)

Comment 1

12 years ago
Created attachment 196276 [details] [diff] [review]
patch

This patch keeps currentScale clamped to what are hopefully safe values.

For the record I tried doing this in WillModify/DidModify, but it isn't
possible. Once you get past the first issues (hint - recursion) you find that
it's impossible to dispatch event's with the correct data when you need to
clamp.
Attachment #196276 - Flags: superreview?(tor)
Attachment #196276 - Flags: review?(tor)

Updated

12 years ago
Attachment #196276 - Flags: superreview?(tor)
Attachment #196276 - Flags: superreview+
Attachment #196276 - Flags: review?(tor)
Attachment #196276 - Flags: review+
(Assignee)

Comment 2

12 years ago
Comment on attachment 196276 [details] [diff] [review]
patch

Requesting approval. It's very important that we include this in FF1.5. The
risk is next to nothing.
Attachment #196276 - Flags: approval1.8b5?
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Attachment #196276 - Flags: approval1.8b5? → approval1.8b5+

Comment 3

12 years ago
Comment on attachment 196276 [details] [diff] [review]
patch

we're now locked down and in ship mode for 1.8b5. If you'd like to re-request
approval for this change, please set the approval1.8rc1? flag.
Attachment #196276 - Flags: approval1.8b5+ → approval1.8b5-
(Assignee)

Comment 4

12 years ago
Sorry Asa, this is actually already landed. I just forgot to add the fixed1.8
keyword.
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.