Closed
Bug 308806
Opened 19 years ago
Closed 19 years ago
Object.prototype.toLocaleString() wrong
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: stryker330, Assigned: mrbkap)
Details
(Keywords: js1.6, verified1.8)
Attachments
(2 files, 1 obsolete file)
490 bytes,
text/html
|
Details | |
2.47 KB,
patch
|
brendan
:
review+
shaver
:
review+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4 Object.prototype.toLocaleString should return the result of toString(). Right now, it's set to simply return "[object Object]". That means that if toString is modified, calling toLocaleString() won't reflect the change. Reproducible: Always Steps to Reproduce: var o = {toString: function() { return 'foo'; }}; o.toLocaleString(); Actual Results: "[object Object]" Expected Results: "foo"
Reporter | ||
Comment 1•19 years ago
|
||
Reporter | ||
Comment 2•19 years ago
|
||
Forgot to mention that both IE6 and Opera8 have the correct behavior.
Updated•19 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 3•19 years ago
|
||
Easy to fix, alfred says it comes up now and then. Blake, can you take this bug and fix it for 1.8b5? /be
Flags: blocking1.8b5?
Keywords: js1.6
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•19 years ago
|
||
Brendan, is this something like what you had in mind?
Attachment #197729 -
Flags: review?(brendan)
Assignee | ||
Comment 6•19 years ago
|
||
It helps to change _all_ occurances of a changed function namne...
Attachment #197729 -
Attachment is obsolete: true
Attachment #197730 -
Flags: review?(brendan)
Assignee | ||
Updated•19 years ago
|
Attachment #197729 -
Flags: review?(brendan)
Comment 7•19 years ago
|
||
Is this a regression? What's the risk of taking this patch? Bob, do we have tests around this?
Comment 8•19 years ago
|
||
(In reply to comment #7) > Is this a regression? I don't know off hand, but will find out asap. > Bob, do we have tests around this? No, but we will have in a few minutes.
Flags: testcase?
Comment 9•19 years ago
|
||
2005-09-29 12:09 bob%bclary.com mozilla/ js/ tests/ js1_5/ Object/ regress-308806-01.js 1.1 0/0 Object.prototype.toLocaleString should track Object.prototype.toString, Regression test for bug 308806 by Bryant Chen, not part of the build This test fails in Mozilla 1.4, Firefox 1.0 and today's Firefox 1.5.
Flags: testcase? → testcase+
Assignee | ||
Updated•19 years ago
|
Attachment #197730 -
Flags: review?(shaver)
Comment on attachment 197730 [details] [diff] [review] Actually compiling r=shaver
Attachment #197730 -
Flags: review?(shaver) → review+
Assignee | ||
Comment 11•19 years ago
|
||
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•19 years ago
|
||
Comment on attachment 197730 [details] [diff] [review] Actually compiling This fix is extremely safe (only affects callers of toLocaleString) and fixes a standards compliance issue by simply doing what the spec tells us to do (return the result of toString).
Attachment #197730 -
Flags: approval1.8b5?
Comment 13•19 years ago
|
||
Comment on attachment 197730 [details] [diff] [review] Actually compiling Nit: canonical name for a JSString * is str. /be
Attachment #197730 -
Flags: review?(brendan) → review+
Updated•19 years ago
|
Attachment #197730 -
Flags: approval1.8b5? → approval1.8b5+
Updated•19 years ago
|
Flags: blocking1.8b5? → blocking1.8b5+
Comment 15•18 years ago
|
||
verified fixed 1.8.x and trunk.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8 → verified1.8
You need to log in
before you can comment on or make changes to this bug.
Description
•