308806 - Object.prototype.toLocaleString() wrong

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Yuh-Ruey Chen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

Object.prototype.toLocaleString should return the result of toString(). Right
now, it's set to simply return "[object Object]". That means that if toString is
modified, calling toLocaleString() won't reflect the change.

Reproducible: Always

Steps to Reproduce:
var o = {toString: function() { return 'foo'; }};
o.toLocaleString();

Actual Results:  
"[object Object]"

Expected Results:  
"foo"

Comment 1

[Yuh-Ruey Chen]

Attachment: testcase

Comment 2

[Yuh-Ruey Chen]

Forgot to mention that both IE6 and Opera8 have the correct behavior.

Comment 3

[Brendan Eich [:brendan]]

Easy to fix, alfred says it comes up now and then.  Blake, can you take this bug
and fix it for 1.8b5?

/be

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Sure.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Implement toLocaleString in the image of ECMA-262

Brendan, is this something like what you had in mind?

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Actually compiling

It helps to change _all_ occurances of a changed function namne...

Comment 7

[Asa Dotzler [:asa]]

Is this a regression? What's the risk of taking this patch? Bob, do we have
tests around this?

Comment 8

[Bob Clary [:bc] (inactive)]

(In reply to comment #7)
> Is this a regression? 

I don't know off hand, but will find out asap.

> Bob, do we have tests around this?

No, but we will have in a few minutes.

Comment 9

[Bob Clary [:bc] (inactive)]

2005-09-29 12:09	bob%bclary.com 	mozilla/ js/ tests/ js1_5/ Object/
regress-308806-01.js 	1.1 	0/0  	Object.prototype.toLocaleString should track
Object.prototype.toString, Regression test for bug 308806 by Bryant Chen, not
part of the build


This test fails in Mozilla 1.4, Firefox 1.0 and today's Firefox 1.5.

Comment 10

[Mike Shaver (:shaver emeritus)]

Comment on attachment 197730 [details] [diff] [review]
Actually compiling

r=shaver

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 197730 [details] [diff] [review]
Actually compiling

This fix is extremely safe (only affects callers of toLocaleString) and fixes a
standards compliance issue by simply doing what the spec tells us to do (return
the result of toString).

Comment 13

[Brendan Eich [:brendan]]

Comment on attachment 197730 [details] [diff] [review]
Actually compiling

Nit: canonical name for a JSString * is str.

/be

Comment 14

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into MOZILLA_1_8_BRANCH.

Comment 15

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.x and trunk.