308835 - calendar magic style sheet not being populated

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

For some time, I've been seeing complaints about the calendar pref style sheet
not being found.  Turns out this was a race: the code that does the setup was
sometimes running before the stylesheet was available to the DOM.  Solved by
creating a general load listener, consolidating a bit of other code into that,
and not doing the stylesheet setup until then.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: use load listener, v1

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 196337 [details] [diff] [review]
use load listener, v1

Bah.  I'm seeing the race again.  So apparently I just thought this patch fixed
it, when in fact I coincidentally won the race a bunch of times in a row while
testing.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

The race seems to be of a different nature than I thought.  According to DOMI,
on runs when I see that error message, it's not that the stylesheet shows up
late; in fact, it's not showing up at all.

Comment 4

[Joey Minta]

Attachment: get chrome stylesheet

I'm pretty sure this is the solution we agreed on in IRC.

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 197132 [details] [diff] [review]
get chrome stylesheet

Hrm.  I think I'd prefer to either do a full-URL match, or just give that
stylesheet the title we were using before.

Though, honestly, we could just grab the last stylesheet and use it, and lose
only some debugging juice.

r=shaver with whatever of those paths you take.  Wish I knew why we had that
problem, though. =/

Comment 6

[Joey Minta]

patch checked in