308854 - ctrl-up too many times in search box breaks search box

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Chris Nuccitelli]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050915 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050915 Firefox/1.4

If you use ctrl-up in the search box to go farther up than the top search
engine, hotkeys (ctrl-up/down and enter) stop working in the search box.

Reproducible: Always

Steps to Reproduce:
1. Ctrl-K to focus search box
2. Ctrl-Up past top search engine (Google)


Actual Results:  
Hotkeys (ctrl-up/down and enter) stop working in the search box

Expected Results:  
Hotkeys should continue to work

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

This appears to have regressed between 9/08 and 9/15.

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

First introduced to the 1.8 branch on 09/14.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

The template is also a sibling, the old setter was more tolerant.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/browser/base/content/search.xml; new revision: 1.30;

Comment 5

[:Gavin Sharp [email: [e-mail]]]

1.8 Branch:
mozilla/browser/base/content/search.xml; new revision: 1.25.2.4;