30887 - Double-click Next in new acct wizard crashes

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[laurel]

Using 2000-03-07-09m15 commercial build on NT 4.0
Can't reproduce on linux or mac

When in new account wizard, a double-click (by accident, of course) on a Next
button causes a crash. 

1.  From mail window, Edit|Account Settings.
2.  Click New Account to bring up new account wizard.
3.  Select mail account, click Next to get to the next panel.
4.  When in next panel, double-click the Next button.

Result:  crash occurs. 

Note:  I believe the crash may only happen when double-clicking in a panel where
incorrect/insufficient information has been entered which would cause an alert
dialog to come up.

Comment 1

[laurel]

Attachment: stack from talkback incident 6449388

Comment 2

[laurel]

.

Comment 3

[laurel]

Nevermind what I said above about the alert dialog.  It crashes even when on the
last couple panels with everything filled in properly.

Comment 4

[Alec Flett]

wierd. thanks for the stack trace, this looks like something is getting funky
when overlays get interrupted or something.

assigning to waterson, cc hyatt. The Next button loads new content in the
account wizard's IFRAME, double clicking probably results in trying to load
another document before the current one is completely loaded.

Comment 5

[Chris Waterson]

Attachment: proposed fix. check mDocument before dereferencing in SetAttribute()

Comment 6

[Chris Waterson]

The fix is trivial. Make sure we check mDocument before dereferencing it in 
nsXULElement::SetAttribute().

PDT: I think we should get this in for Beta1. This fix is a no-brainer, 
and there have been other reports of this bug on the newsgroups. Whenever you 
try to set the 'style' attribute on a XUL element that is not in the DOM, you 
crash.

Comment 7

[Phil Peterson]

[PDT+] w/b minus on 3/8 for trivial fix in hand

Comment 8

[Chris Waterson]

fix checked in, r=hyatt a=jar

Comment 9

[Alec Flett]

woah, that was fast. Thanks chris.

Comment 10

[laurel]

OK using 2000-03-08-13m15 commercial build on NT 4.0