308888 - Alt+clicking bookmark in sidebar gives "Error: saveURL is not defined"

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Open the bookmarks sidebar.
2. Alt+Click on any item.

Result: "Error: saveURL is not defined" appears in the JavaScript console.

Expected: Save the URL the bookmark points to.

I'm using my own trunk build of Firefox on Mac.  It is up to date as of a few
hours ago.  I don't know whether this is a regression.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

cvs-blame says "Some modifier cleanup; fix load in background pref." ;)

Comment 2

[Jesse Ruderman]

This bug also exists in Firefox 1.0 and Firefox 1.0.7 RC3, so I guess it's not a
recent regression ;)

Comment 3

[Asaf Romano (gone)]

Checking in browser/components/bookmarks/content/bookmarks.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarks.js,v  <-- 
bookmarks.js
new revision: 1.107; previous revision: 1.106
done
Checking in browser/components/bookmarks/content/bookmarksPanel.xul;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksPanel.xul,v  <--
 bookmarksPanel.xul
new revision: 1.19; previous revision: 1.18
done

Comment 4

[Asaf Romano (gone)]

1.8 Branch:
Checking in browser/components/bookmarks/content/bookmarks.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarks.js,v  <-- 
bookmarks.js
new revision: 1.104.2.2; previous revision: 1.104.2.1
done
Checking in browser/components/bookmarks/content/bookmarksPanel.xul;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksPanel.xul,v  <--
 bookmarksPanel.xul
new revision: 1.18.10.1; previous revision: 1.18
done