308947 - saving prefs are wrong at printing

Status: RESOLVED INVALID

(Core :: Printing: Output, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is my regression from bug 118563.
We should not use kInitSaveAll.
XP dialog using following code:

> 414     var flags = gPrintSetInterface.kInitSavePaperSizeType  | 
> 415                 gPrintSetInterface.kInitSavePaperSizeUnit  |
> 416                 gPrintSetInterface.kInitSavePaperWidth     | 
> 417                 gPrintSetInterface.kInitSavePaperHeight    |
> 418                 gPrintSetInterface.kInitSavePaperName      | 
> 419                 gPrintSetInterface.kInitSaveColorSpace     |
> 420                 gPrintSetInterface.kInitSaveInColor        |
> 421                 gPrintSetInterface.kInitSaveResolutionName |
> 422                 gPrintSetInterface.kInitSaveDownloadFonts  |
> 423                 gPrintSetInterface.kInitSavePrintCommand   |
> 424                 gPrintSetInterface.kInitSaveShrinkToFit    |
> 425                 gPrintSetInterface.kInitSaveScaling;

I think we shouldn't save ShrinkToFit and Scaling to each printer settings.
Because these values are changed by print preview. Of cause, we should save
other informations to grobal prefs.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Sorry. This bug is wrong. We should save all data for each printer.
We don't read prefs when user select the printer.
# if we read prefs when user select the printer, we should not save all data.

-> INVA