308976 - timepicker displays 'undefined' if alphabetic month format: "this.dateservice has no properties"

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20050917 Mozilla Sunbird/0.2+

If the month format is alphabetic (dd-MMM-yy, 17-Sep-05)
then event dialog timepickers display 'undefined' 
and javascript console has error "this.dateService has no properties"

Reproducible: Always

Steps to Reproduce:
1. Set o.s. short date format to dd-MMM-yy 
   (on w2k: control panel | regional options | date | short date format)
2. start sunbird
3. new event

Actual Results:  
start date is ok, but start time is 'undefined'
end   date is ok, but end   time is 'undefined'

Error: this.dateService has no properties
Source File: chrome://calendar/content/datetimepickers/datetimepickers.xml
Line: 1274

Expected Results:  
start and end times should be formatted as times

Comment 1

[gekacheka]

Attachment: this.dateService.FormatDate --> this.formatDate

(patch -l -p 2 -i file.patch)

Problem was leftover call to this.dateService which no longer exists.

With this patch, using dd-MMM-yy date format, opening event dialog no longer
produces errors about this.dateService, and start time and end time fields are
no longer 'undefined'.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 196451 [details] [diff] [review]
this.dateService.FormatDate --> this.formatDate

r=mvl

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in