308992 - tinderbox should do respin when last-built removed even if before build hour

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What's really a bug in the tinderbox script has been essentially forcing us to
make all the nightly build hours early in the day, because otherwise triggering
respins can be inconvenient.  We should really just fix this bug in the script.
 In particular, removing the last-built file should always trigger a respin.  (I
think we also may have some first-day-of-the-year bugs that the patch I'll
attach shortly should fix, since it does all time *comparisons* (although not
manipulation) by comparing seconds-since-the-epoch values.)

This also fixes one other bug in post-mozilla-rel.pl that I noticed a while back
and forgot to attach the patch for:  there's a find command at the end that's
*really* slow since it searches the entire srcdir and objdir when it just wants
subdirectories $mozilla_build_dir.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (not yet tested)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I've tested a whole bunch of cases (and made the previous patch compile, and
fixed a backward comparison, and made it print more info to the log).

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In particular:
 * no last-built ==> $cachebuild is 1
 * I tested last-built just over and just under 24 hours old, and verified that
it took different codepaths for getting to $cachebuild = 1
 * I tested last-built just before and just after the build hour, and verified
that it changed $cachedbuild
 * I tested that last-built in the future does not generate a build (we really
shouldn't be generating nightlies on machines with wacky clocks)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And I tested adding the "-maxdepth 1" to the find command in the directory where
that command is used on comet.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Actually, that was more complicated than necessary.  This simplifies it.

Comment 6

[Chase Phillips]

Comment on attachment 196470 [details] [diff] [review]
patch

Good stuff here.  Land at your convenience.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed (along with a comment fix reflecting the improvement I made in comment 5,
i.e., that I didn't need an explicit 24-hours check).