308996 - EM ui should use default richlistbox appearance

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

The EM ui extension list has a background color specified in extensions.css for
winstripe and qute.
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/mozapps/extensions/extensions.css#73
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/qute/mozapps/extensions/extensions.css#86

It should probably just use the defaults provided by richlistbox
http://lxr.mozilla.org/seamonkey/source/toolkit/content/xul.css#1043
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/richlistbox.css#40

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: sreenshot before

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: sreenshot after

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 4

[Robert Strong (they/them - no direct email)]

I have verified that win32 still displays the same as without this patch and it
will probably fix situations on win32 when not using the default OS theme.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch for the EM and DM

This fixes the download manager and also removes the redundant -moz-appearance

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 196493 [details] [diff] [review]
patch for the EM and DM

mmm, good call!

should be totally safe for branch, and I think we want this no-risk polish fix.

Comment 7

[Robert Strong (they/them - no direct email)]

Fixed on trunk

Checking in mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css,v  <--
 downloads.css
new revision: 1.13; previous revision: 1.12
done
Checking in mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v 
<--  extensions.css
new revision: 1.19; previous revision: 1.18
done
Checking in mozilla/toolkit/themes/qute/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/extensions.css,v  <-- 
extensions.css
new revision: 1.15; previous revision: 1.14
done

Comment 8

[Robert Strong (they/them - no direct email)]

Comment on attachment 196493 [details] [diff] [review]
patch for the EM and DM

Requesting 1.8b5 approval for this no-risk polish fix.

Comment 9

[Mike Schroepfer]

Comment on attachment 196493 [details] [diff] [review]
patch for the EM and DM

Approved for 1.8b5 per bug meeting

Comment 10

[Robert Strong (they/them - no direct email)]

Fixed on MOZILLA_1_8_BRANCH

Checking in mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css,v  <--
 downloads.css
new revision: 1.12.2.1; previous revision: 1.12
done
Checking in mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v 
<--  extensions.css
new revision: 1.16.2.3; previous revision: 1.16.2.2
done
Checking in mozilla/toolkit/themes/qute/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/extensions.css,v  <-- 
extensions.css
new revision: 1.13.2.2; previous revision: 1.13.2.1
done