309000 - Views should use exclusive end date to get events

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20050917 Mozilla Sunbird/0.2+

Bug 290722 made interfaces use exclusive end datetimes in range, but views are
still using inclusive end datetimes.  They should use exclusive end dates.

(one symptom:  exception dates are dates, not datetimes.  Dates are compared
with datetimes without regard to time.  
So given range today 0:00 -- today 23:59 and comparing with an exception date to
see if 
  today 0:00 <= exceptionDate 0:00 < today 23:59 
is effectively 
  today 0:00 <= exceptionDate 0:00 < today 0:00
which is always false.  With the exlusive end date, the range test would be
  today 0:00 <= exceptionDate 0:00 < tomorrow 0:00.)

Reproducible: Always

Steps to Reproduce:

Comment 1

[gekacheka]

Attachment: Use exclusive end date on range in queries for views

(patch -l -p 2 -i file.patch)

Old code subtracted a second or a millisecond, new code removes that
subtraction.
Also, code that checks if item is in range may have now encounter end date
which is equal to start of range.  An item that ends at start of range is only
in range if it also starts at start (0 duration event).

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

The problem with exception sounds very much like a backend problem. It shouldn't
return items that should not be returned, no matter what the end time is. It is
perfectly valid to query for events between 6:00 and 12:00. That should just work.
This patch looks like a workaround.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 196484 [details] [diff] [review]
Use exclusive end date on range in queries for views

r=me, but do file a bug on the recurrance problem. It very much sounds like a
backend problem we need to fix.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in