309026 - Password manager clears all the stored passwords at exit

Status: RESOLVED WORKSFORME

(Toolkit :: Password Manager, defect)

Description

[Tuomo Tikkanen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

When I close Firefox it clears all the stored passwords from password manager. I
first thought that this was a bug in import profile import (I moved from Mozilla
suite to FF 1.5b1), but shortly learned that it is actually a bug in FF.

There is an option in the 'Clear Private Data' dialog box
(Edit->Preferences->Privacy->Password->Settings) to clear saved passwords when
closing FF. By default it is not checked though and thus saved passwords should
not be cleared automatically. I have tested the setting on and off and it do not
matter what is the status of this line in 'Clear Private Data' dialogbox the
passwords are cleared every time I exit FF.

I have checked from 'about:config' that the value of 'privacy.item.passwords'
setting is changed false to true and vice versa when related checkbox is set or
unset in 'Clear Private Data' dialogbox. It just seems to be so that this value
is not used to make the decision whether the stored passwords are cleared or not.

This is really making the whole password manager unusable. Now I have to import
the passwords from my old Mozilla profile to FF everytime I start FF. Also if I
know enter some new passwords that are not yet in password manager I'll lose
them too and can even get them back from old Mozilla profile, because they are
not there.

Reproducible: Always

Steps to Reproduce:
1. Import passwords from old Mozilla profile
2. Check that in Edit->Preferences->Privacy->Password->Settings dialog box
'Saved Passwords' is not checked
3. Exit from Firefox

Actual Results:  
Saved passwords are cleared.

Expected Results:  
Saved passwords should not have been cleared.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050917
Firefox/1.6a1 ID:2005091723

This works well in Windows. Would have generated massive complaints.
Related to the "Clear Private Data" trouble in Bug 308940 and Bug 308384 ?

Comment 2

[Tuomo Tikkanen]

Attachment: Odd selections and missing checkboxes and buttons

Comment 3

[Tuomo Tikkanen]

Attachment: Actual used when settings for Bad CPD was got

Comment 4

[Tuomo Tikkanen]

Attachment: Dialog box got when restarted FF

This is the dialogbox got after restarting FF when it did not crash, but didn't
either show the CPD dialogbox at exit even though it should have done so based
on user settings.

Comment 5

[Tuomo Tikkanen]

Yes this seems to be related to named bugs in Comment #1 and also Bug 307840
seems to be match for this bug.

I have now further tested the bug and when I turned on the 'Clear private data
when closing Firefox' Firefox started to behave very oddly when closing FF.

Sometimes (most often) it just crashes after I have selected either 'Cancel' or
'Clear Private Data Now' button. However the dialog box itself is missing
checkboxes and buttons and also the disabled selections seem to be somewhat
random and anyhow not to related to anything (see attachment 1 [details] [diff] [review], attachemtn 2
shows the actualua CPD selections I have set when this was got). The Talkback
dialog opens, but if I try to check the details the Talkback dialog just
dissappears. If I press send button the Talkback dialog just dissapperas too.

Sometimes (less often) the FF just quits, but does not show the dialog box to
clear private data. However when I restart FF I'll got the CPD dialogbox that I
should have got earlier. This time the decorations are all OK, but disabled
items are still random (see attachment 3 [details] [diff] [review]). Then now matter which button I select
the dialogbox just dissappears and FF is started (with password manager list
cleared).

Clearly this is some sort of dangling pointer or freed memory problem that
causes this kind of random behaviour.

Comment 6

[Adam Guthrie]

Definitely related to bug 307840. Tuomo, could you please post the talkback ID
of the crash here?

Comment 7

[Tuomo Tikkanen]

I'd like to provide you the Talkback ID, but how I get it? I just get the
talkback window, but I do not see any ID there and if I press "details" button
the talkback window just disappears.

Comment 8

[Tuomo Tikkanen]

Talkback incident IDs related to the issue:
TB9474464W
TB9474246X
TB9474235E
TB9474229K
TB9474082W
TB9474076Y
TB9474075E
TB9473855W
TB9472943G
TB9472938G

Comment 9

[Adam Guthrie]

Tuomo, can you please retest in the latest builds? Supposedly this is fixed, but
I seriously don't see how this could have been fixed. Thanks.

Comment 10

[Tuomo Tikkanen]

(In reply to comment #9)
> Tuomo, can you please retest in the latest builds? Supposedly this is fixed, but
> I seriously don't see how this could have been fixed. Thanks.

Sorry for a late answer, but I have been abroad and away from computers few days.

I just today downloaded and installed 1.5b2 and I am sad to report that
basically the problem still exists in this version too. What have changed though
is that now the dialog boxes are "sound" in the way that the checkboxes and
buttons in them are now visible. Also the greyed items seem to have now some
relationship to the reality in the way that items that do not exist are greyed
out and can not be selected. So the visual part of the problem is somehow solved
I guess.

Unfortunately the real problem i.e. always clearing the saved passwords and not
honoring my selections is still existing. Actually it seems to be so that if I
select the "Saved Passwords" to be cleared the browser crashes. Otherwise it
seems not to crash anymore at exit (only a few tries though).

Comment 11

[Tuomo Tikkanen]

Actually the crashing seems to be related to situation when the saved passwords
list is already empty and one exits from the FF. This happens for example when
one once exited from the FF and then one restarted the browser without importing
the saved passwords from the old Mozilla profile. This is quite understandable
consedering that the FF is always clearing saved password data. Thus when there
is no data/file to be cleared browser is doing something very bad and thus crashing.

To see this do following:
1) Start FF
2) Import Saved Passwords from Mozilla profile
3) Exit FF
NO crash here, but Saved Passwords are cleared no matter what your choices have
been.
4) Start FF
5) Exit FF
CRASH! No matter what your choices have been.

Related Talkback incident IDs:
TB10427856Z
TB10428486M
TB10436663Y
TB10436682Y

Comment 12

[timeless]

Incident ID: 10427856
Stack Signature	libgobject-2.0.so.0 + 0x29d4d (0x00dc2d4d) 44a1964b
Product ID	Firefox15
Build ID	2005100604
Trigger Time	2005-10-09 08:20:27.0
Platform	LinuxIntel
Operating System	Linux 2.6.12-1.1378_FC3
Module	libgobject-2.0.so.0 + (00029d4d)
URL visited	
User Comments	
Since Last Crash	0 sec
Total Uptime	0 sec
Trigger Reason	SIGSEGV: Segmentation Fault: (signal 11)
Source File, Line No.	N/A
Stack Trace 	
libgobject-2.0.so.0 + 0x29d4d (0x00dc2d4d)
libgtk-x11-2.0.so.0 + 0x1fee5b (0xb7d21e5b)
nsDragService::Observe() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/widget/src/gtk2/nsDragService.cpp,
line 137]
nsObserverService::NotifyObservers() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/xpcom/ds/nsObserverService.cpp,
line 848]
nsAppStartup::Quit() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/toolkit/components/startup/src/nsAppStartup.cpp,
line 848]
nsAppStartup::Observe() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/toolkit/components/startup/src/nsAppStartup.cpp,
line 522]
nsObserverService::NotifyObservers() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/xpcom/ds/nsObserverService.cpp,
line 848]
nsXULWindow::Destroy() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/xpfe/appshell/src/nsXULWindow.cpp,
line 848]
nsWebShellWindow::Destroy() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp,
line 850]
nsChromeTreeOwner::Destroy() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/xpfe/appshell/src/nsChromeTreeOwner.cpp,
line 354]
nsGlobalWindow::ReallyCloseWindow() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/dom/src/base/nsGlobalWindow.cpp,
line 848]
nsGlobalWindow::CloseWindow() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/dom/src/base/nsGlobalWindow.cpp,
line 751]
nsJSContext::ScriptEvaluated() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/dom/src/base/nsJSEnvironment.cpp,
line 2036]
nsCxPusher::Pop() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/content/base/src/nsContentUtils.cpp,
line 848]
nsEventListenerManager::HandleEventSubType() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/content/events/src/nsEventListenerManager.cpp,
line 666]
nsEventListenerManager::HandleEvent() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/content/events/src/nsEventListenerManager.cpp,
line 1784]
nsXULElement::HandleDOMEvent() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/content/xul/content/src/nsXULElement.cpp,
line 2153]
PresShell::HandleDOMEventWithTarget() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/layout/base/nsPresShell.cpp,
line 6462]
nsButtonBoxFrame::DoMouseClick() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/layout/xul/base/src/nsButtonBoxFrame.cpp,
line 179]
nsButtonBoxFrame::HandleEvent() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/layout/xul/base/src/nsButtonBoxFrame.cpp,
line 150]
PresShell::HandleEventInternal() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/layout/base/nsPresShell.cpp,
line 6407]
PresShell::HandleEventWithTarget() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/layout/base/nsPresShell.cpp,
line 6265]
nsEventStateManager::CheckForAndDispatchClick() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/content/events/src/nsEventStateManager.cpp,
line 3038]
nsEventStateManager::PostHandleEvent() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/content/events/src/nsEventStateManager.cpp,
line 165]
PresShell::HandleEventInternal() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/layout/base/nsPresShell.cpp,
line 848]
PresShell::HandleEvent() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/layout/base/nsPresShell.cpp,
line 6202]
nsViewManager::HandleEvent() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/view/src/nsViewManager.cpp,
line 848]
nsViewManager::DispatchEvent() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/view/src/nsViewManager.cpp,
line 2246]
HandleEvent() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/view/src/nsView.cpp,
line 251]
nsCommonWidget::DispatchEvent() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/widget/src/gtk2/nsCommonWidget.cpp,
line 219]
nsWindow::OnButtonReleaseEvent() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/widget/src/gtk2/nsWindow.cpp,
line 1594]
button_release_event_cb() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/widget/src/gtk2/nsWindow.cpp,
line 3722]
libgtk-x11-2.0.so.0 + 0x10d677 (0xb7c30677)
libgobject-2.0.so.0 + 0x9347 (0x00da2347)
libgobject-2.0.so.0 + 0x1fae1 (0x00db8ae1)
libgobject-2.0.so.0 + 0x20913 (0x00db9913)
libgobject-2.0.so.0 + 0x20f5a (0x00db9f5a)
libgtk-x11-2.0.so.0 + 0x2012d5 (0xb7d242d5)
libgtk-x11-2.0.so.0 + 0x10b93b (0xb7c2e93b)
libgtk-x11-2.0.so.0 + 0x10bc40 (0xb7c2ec40)
libgdk-x11-2.0.so.0 + 0x3d0c2 (0xb7af40c2)
libglib-2.0.so.0 + 0x237bb (0x00d1a7bb)
libglib-2.0.so.0 + 0x25242 (0x00d1c242)
libglib-2.0.so.0 + 0x25728 (0x00d1c728)
nsAppShell::DispatchNativeEvent() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/widget/src/gtk2/nsAppShell.cpp,
line 276]
nsXULWindow::ShowModal() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/xpfe/appshell/src/nsXULWindow.cpp,
line 848]
nsContentTreeOwner::ShowAsModal() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/xpfe/appshell/src/nsContentTreeOwner.cpp,
line 431]
nsWindowWatcher::OpenWindowJS() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp,
line 848]
nsWindowWatcher::OpenWindow() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp,
line 476]
XPTC_InvokeByIndex()
XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode)() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,
line 2138]
XPC_WN_CallMethod() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp,
line 1402]
js_Invoke() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/js/src/jsinterp.c,
line 1163]
js_Interpret() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/js/src/jsinterp.c,
line 3487]
js_Invoke() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/js/src/jsinterp.c,
line 1183]
nsXPCWrappedJSClass::CallMethod() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp,
line 1339]
nsXPCWrappedJS::CallMethod() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp,
line 462]
PrepareAndDispatch() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_gcc_x86_unix.cpp,
line 100]
nsObserverService::NotifyObservers() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/xpcom/ds/nsObserverService.cpp,
line 848]
nsXREDirProvider::DoShutdown() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/toolkit/xre/nsXREDirProvider.cpp,
line 642]
ScopedXPCOMStartup::~ScopedXPCOMStartup() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/toolkit/xre/nsAppRunner.cpp,
line 550]
XRE_main() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/toolkit/xre/nsAppRunner.cpp,
line 848]
main() 
[/builds/tinderbox/Fx-Mozilla1.8/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/browser/app/nsBrowserApp.cpp,
line 62]
libc.so.6 + 0x14e23 (0x0098ce23)

Comment 13

[Adam Guthrie]

Tuomo, if you could test this in the most recent builds (after the patch for bug
307840 landed) that'd be great. (Might want to wait a few hours before you grab
a build.)

Comment 14

[mna]

seem to be solved in 1.5 rc2 

(Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051107 Firefox/1.5)

Comment 15

[Adam Guthrie]

Tuomo, please reopen if you can reproduce in 1.5 RC2.