309118 - Remove the vertical-align hack in html.css once bug 1156 is fixed

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The code will just need to go away and the attr mapping get fixed instead.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So this is not so trivial to do, since I'd basically need to create a new mapped
attributes with a different attribute mapping function to handle this in the
content node....

Comment 2

[Boris Zbarsky [:bzbarsky]]

Note that we do need to not vertical-align because of bug 36997.  It's too bad
we can't tell apart <object align="top">2</object> (which we _would_ want to
align) from <object align="top"><embed></object> (which looks quite bad when
aligned).

Perhaps we should instead inherit the align down to kids of broken objects by
default?  That should more or less fix the cases that had issues in bug 36997, I
believe...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 197204 [details] [diff] [review]
Proposed patch

This seems reasonable, but I wonder how compatible it is with what other
browsers do.  Worth checking, but sr=dbaron.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yeah, this is not compatible with what IE and Opera do.  It's compatible with
what IE does when it can handle the outer object and we can't, so I think it's
still worth landing in 1.9 and seeing what happens.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Hmm...  This caused a bit of a Tp hit (0.5% to 1%?) on btek and maybe luna.