309140 - Fix help button placement under UNIX

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Mary Ellen Foster]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

In Linux Firefox 1.5 Beta 1, the "Edit / Preferences" dialogue box has two
buttons on it: "Help" and "Close". These are placed on the lower right of the
dialogue box, and look a *lot* like they should be "OK" and "Cancel" if you
don't look too closely at them. The result is that, almost every time I change
my preferences, I end up inadvertently opening the help because I clicked on the
"Help" button in an attempt to dismiss the window.

Maybe "Help" could be over on the left instead of on the right next to "Close"?

Reproducible: Always

Steps to Reproduce:
1. Choose "Edit / Preferences" from the menu
2. Change some preferences
3. Try to close window by clicking on most obvious button
Actual Results:  
Help opens, because I ended up clicking on "Help"

Expected Results:  
Not put the "Help" button where it looks like an "OK" button

Comment 1

[Mike Connor [:mconnor]]

Help should be on the left for GNOME, per the HIG, but we have some issues
there.  Patch upcoming.

Comment 2

[Mike Connor [:mconnor]]

Attachment: first cut

needs mac testing

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 196674 [details] [diff] [review]
first cut

This moves the Help button on Mac to the bottom left in all cases, not just
where there's other buttons.  The behaviour without other buttons present isn't
specified in the HIG, and seems more like a flaw in the native widget than a
reasoned discussion.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 196674 [details] [diff] [review]
first cut

r=mano on the toolkit/ changes.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 196674 [details] [diff] [review]
first cut

subtle alignment stuff, not risky/well tested

Comment 6

[Mike Schroepfer]

Comment on attachment 196674 [details] [diff] [review]
first cut

Approved per 9/26 bug triage meeting.