309157 - "All Day" events cropped in Week View

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[jrx]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050916 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050918 Mozilla Sunbird/0.2+

In Week View, "All Day" events are cropped to the first two letters.

Reproducible: Always

Steps to Reproduce:
1.Create all day event
2.Switch to week view
3.

Actual Results:  
Cropped event

Expected Results:  
Display the event title along the whole width of the column for that day.

Comment 1

[Joey Minta]

Confirming.  See Bug 306644 comment #3.

Comment 2

[Joey Minta]

Attachment: better elementOfRef

As I said in the comment on the previous bug, since all-day events have a
start-hour of midnight, the patch there causes an proper ElementOfRef to no
longer be found.  The element that is found is collapsed, and hence has no
width.	This patch checks for that case, and then gets an element of reference
based on the view limit default, which will always be visible.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 196755 [details] [diff] [review]
better elementOfRef

Why not always use sHour? That should always be visible, right? Hmm, it might
be faster not to ask the pref service.
Do what you think is best. r=mvl

Comment 4

[Joey Minta]

Patch checked in, without changes.  I agree that asking the pref service every
time would be worse.