309185 - [Regression] "Show last search results" != "show list"

Status: RESOLVED WORKSFORME

(Bugzilla :: Query/Bug List, defect)

Description

[Brian G. Peterson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

The new "Show last search results" in Bugzilla version 2.20rc2 should show the
results of the last search performed by the user.  Instead, it seems to show
lists generated by the last report run.

I can find no way to clear this parameter.

Using Saved Searches produces the same result.  Bugzilla is inconsistent about
which prior search it decides to show when "Show last search results" is
pressed, but routinely does not show the 'last search' performed by the user.

Reproducible: Always

Steps to Reproduce:
1. run a few searches and/or saved searches
2. drill down into one of the bugs
3. select "Show last search results" 

Actual Results:  
Bugzilla 2.20rc2 shows some previous search, but not the immediately previous
search.  I suspect that the most recent search parameters are not always getting
correctly copied into the cache.

Expected Results:  
Shown the most recently run search.

Comment 1

[Brian G. Peterson]

*** Bug 309186 has been marked as a duplicate of this bug. ***

Comment 2

[Brian G. Peterson]

I believe that this is a bug in 2.20rc2 that should probably be marked as
blocking 2.20.  It is a regression bug in that functionality that previously
worked in all versions we have used up to and including 2.19.1 is now broken.

Comment 3

[Brian G. Peterson]

I notice that when this bug is evident, the 'Next' and 'Prev' links are not
shown either, which adds credence to the theory that the current search is not
getting saved correctly.

Comment 4

[Max Kanat-Alexander]

Seems to work, to me. Reporting uses searches, also, so I can see why that would
happen. That is, any time that you run a report, it runs a search. Anything that
runs a search will probably overwrite your last saved search. You're saying that
didn't used to happen in Bugzilla 2.18? That is, run a search, then run a
report, "last search" will be the report, not the search.

I'm not saying that's the way things *should* be, but I'm not sure this is
actually a regression.

Comment 5

[Brian G. Peterson]

The way you describe is how things should work, but not how they are working for me.

When I run searches via the reports, that is the search that gets copied into
the 'last search'

When I run searches 'manually', via the 'Search' links and advanced search page,
that sarch and the results list do not seem to get copied into the 'last search'
storage.

'Saved Searches' also do *not* seem to get dropped into 'last search'.

I'll be happy to do more troubleshooting, but this is acting very broken, at
least in our environment.  We've been using Bugzilla for years, and make
extensive use of the old 'show list' functionality, now renamed "show last
search results".

Comment 6

[Frédéric Buclin]

I haven't time to verify this problem today. I will have a look at this bug on
Friday. In all cases, that's not a blocker for 2.20.

Comment 7

[Frédéric Buclin]

A saved search is a search and is consequently the "last search".
A search run by reports is a search and is consequently the "last search".
A manual search is a search and is consequently the "last search".

All my tests are successful on both 2.20 and 2.21.1 and everytime a search was
run, its result was saved as the "last search", as expected. Marking WFM.