309209 - The scale of native printer dialog on windows is always ignored

Status: RESOLVED WORKSFORME

(Core :: Printing: Output, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://lxr.mozilla.org/mozilla/source/gfx/src/windows/nsDeviceContextSpecWin.cpp#596
Currently, |SetupDevModeFromSettings| is not changing scale. It should change.
We cannot change print scale from native print dialog.

# I cannot assume that this bug, bug 298142 and bug 174109 are same or not.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'm resetting bugs which are assigned to me but I'm not working on them and I don't have plan for fixing them in near future.

Comment 2

[Daniel Holbert [:dholbert]]

RE the bug title, "The scale of native printer dialog on windows is always ignored": I'm not seeing any scale being "ignored" here at this point, which is good news.

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #0)

http://lxr.mozilla.org/mozilla/source/gfx/src/windows/nsDeviceContextSpecWin.
cpp#596
Currently, |SetupDevModeFromSettings| is not changing scale. It should
change.

Note, this .cpp file still exists (now at https://searchfox.org/mozilla-central/rev/99c3ccc2f02c5fff7c9850f7a0770ee92cc693f6/widget/windows/nsDeviceContextSpecWin.cpp ) but it no longer has a function named SetupDevModeFromSettings.

We cannot change print scale from native print dialog.

This still seems to be true (I tested on Windows with File|Print, "Print using the System Print Dialog", and then choosing the Microsoft Print-to-PDF print target). I couldn't find a way to see or adjust the scale in the system print dialog; nor do I see a way to adjust various other specialized settings like "Print Backgrounds", "Print headers & footers", to set custom margins, etc.) It just lets me choose a page range, number-of-copies, and (after clicking "Preferences" in the system print dialog) I can choose paper orientation & size.

But:

• we now have our own tab-modal print dialog which does let you change the scale (and these various other options like "print headers/footers" etc.), even if the Windows system dialog does not.
• If you change the scale in our print dialog and then click through to "Print using the system dialog" and complete the print, then we do seem to honor the scale that you chose (even though the system print dialog doesn't let you see or adjust it).
• Microsoft's own browser, Edge, seems to give the same experience that we do if you click through from Edge to the system print dialog. (various settings including "scale" aren't available in the system print dialog.) Same goes for Chrome.

So I suspect there's nothing left for us to do here. Tentatively closing as WORSKFORME, with a ni=masayuki to be sure I'm not missing anything.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I don't remember well about this, and I googled about old native print dialog. However, I don't see the "scale" option in the screenshots. It might be my printer driver overrode the common dialog or Firefox (or Seamonkey?) used template but stopped using it.

Anyway, this is not required feature, so I agree with closing this bug.