The default bug view has changed. See this FAQ.

nsEventStateManager needs to support mousewheel.withmetakey

RESOLVED FIXED in mozilla1.8beta5

Status

()

Core
Event Handling
P1
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Mark Mentovai, Assigned: mano)

Tracking

({fixed1.8})

Trunk
mozilla1.8beta5
PowerPC
Mac OS X
fixed1.8
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
Follow-up to bug 171680 comment 23:

Now that scrolling with modifier keys works properly on the Mac, there needs to
be a way to map command-scroll to something.  Currently, only shift, control,
and alt/option are mappable.  Meta/command needs to be added to the list.

The default action for command-scroll (vertical) should be history traversal. 
Shift-scroll is bound this way, but bug 171680 comment 23 says why that's not
reliable on the Mac.
(Reporter)

Comment 1

12 years ago
This should block because it used to be possible to do history traversal with
the scroll wheel on the Mac in 1.0, and now it's not.
No longer blocks: 171680
Depends on: 171680
Flags: blocking1.8b5?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta5
Created attachment 196737 [details] [diff] [review]
patch

I will pref the desired behavior in the app level, in another bug.
Attachment #196737 - Flags: superreview?(roc)
Attachment #196737 - Flags: review?(mark)
(Reporter)

Comment 3

12 years ago
Comment on attachment 196737 [details] [diff] [review]
patch

Mmmkay.  r=me as long as all.js gets defaults for withmetakey when
HORIZSCROLL_AVAILABLE is not defined.
Attachment #196737 - Flags: review?(mark) → review+
(Reporter)

Updated

12 years ago
Blocks: 309345
Priority: -- → P1

Updated

12 years ago
Keywords: regression
Keywords: regression
Blocks: 309730

Comment 4

12 years ago
Comment on attachment 196737 [details] [diff] [review]
patch

I see this code missed the great AppendLiteral sweep :-/ File a bug please.
Attachment #196737 - Flags: superreview?(roc) → superreview+
Attachment #196737 - Flags: approval1.8b5?
Checking in modules/libpref/src/init/all.js;
/cvsroot/mozilla/modules/libpref/src/init/all.js,v  <--  all.js
new revision: 3.599; previous revision: 3.598
done
Checking in content/events/src/nsEventStateManager.cpp;
/cvsroot/mozilla/content/events/src/nsEventStateManager.cpp,v  <-- 
nsEventStateManager.cpp
new revision: 1.614; previous revision: 1.613
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 6

12 years ago
Comment on attachment 196737 [details] [diff] [review]
patch

Approved per 9/26 bug triage meeting.
Attachment #196737 - Flags: approval1.8b5? → approval1.8b5+

Updated

12 years ago
Flags: blocking1.8b5? → blocking1.8b5+
1.8 branch:
Checking in modules/libpref/src/init/all.js;
/cvsroot/mozilla/modules/libpref/src/init/all.js,v  <--  all.js
new revision: 3.585.2.11; previous revision: 3.585.2.10
done
Checking in content/events/src/nsEventStateManager.cpp;
/cvsroot/mozilla/content/events/src/nsEventStateManager.cpp,v  <-- 
nsEventStateManager.cpp
new revision: 1.595.2.9; previous revision: 1.595.2.8
done
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.