309227 - nsEventStateManager needs to support mousewheel.withmetakey

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Mark Mentovai]

Follow-up to bug 171680 comment 23:

Now that scrolling with modifier keys works properly on the Mac, there needs to
be a way to map command-scroll to something.  Currently, only shift, control,
and alt/option are mappable.  Meta/command needs to be added to the list.

The default action for command-scroll (vertical) should be history traversal. 
Shift-scroll is bound this way, but bug 171680 comment 23 says why that's not
reliable on the Mac.

Comment 1

[Mark Mentovai]

This should block because it used to be possible to do history traversal with
the scroll wheel on the Mac in 1.0, and now it's not.

Comment 2

[Asaf Romano (gone)]

Attachment: patch

I will pref the desired behavior in the app level, in another bug.

Comment 3

[Mark Mentovai]

Comment on attachment 196737 [details] [diff] [review]
patch

Mmmkay.  r=me as long as all.js gets defaults for withmetakey when
HORIZSCROLL_AVAILABLE is not defined.

Comment 4

[[e-mail]]

Comment on attachment 196737 [details] [diff] [review]
patch

I see this code missed the great AppendLiteral sweep :-/ File a bug please.

Comment 5

[Asaf Romano (gone)]

Checking in modules/libpref/src/init/all.js;
/cvsroot/mozilla/modules/libpref/src/init/all.js,v  <--  all.js
new revision: 3.599; previous revision: 3.598
done
Checking in content/events/src/nsEventStateManager.cpp;
/cvsroot/mozilla/content/events/src/nsEventStateManager.cpp,v  <-- 
nsEventStateManager.cpp
new revision: 1.614; previous revision: 1.613
done

Comment 6

[Mike Schroepfer]

Comment on attachment 196737 [details] [diff] [review]
patch

Approved per 9/26 bug triage meeting.

Comment 7

[Asaf Romano (gone)]

1.8 branch:
Checking in modules/libpref/src/init/all.js;
/cvsroot/mozilla/modules/libpref/src/init/all.js,v  <--  all.js
new revision: 3.585.2.11; previous revision: 3.585.2.10
done
Checking in content/events/src/nsEventStateManager.cpp;
/cvsroot/mozilla/content/events/src/nsEventStateManager.cpp,v  <-- 
nsEventStateManager.cpp
new revision: 1.595.2.9; previous revision: 1.595.2.8
done