Closed Bug 309227 Opened 15 years ago Closed 15 years ago

nsEventStateManager needs to support mousewheel.withmetakey

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P1)

PowerPC
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta5

People

(Reporter: mark, Assigned: mano)

References

Details

(Keywords: fixed1.8)

Attachments

(1 file)

Follow-up to bug 171680 comment 23:

Now that scrolling with modifier keys works properly on the Mac, there needs to
be a way to map command-scroll to something.  Currently, only shift, control,
and alt/option are mappable.  Meta/command needs to be added to the list.

The default action for command-scroll (vertical) should be history traversal. 
Shift-scroll is bound this way, but bug 171680 comment 23 says why that's not
reliable on the Mac.
This should block because it used to be possible to do history traversal with
the scroll wheel on the Mac in 1.0, and now it's not.
No longer blocks: 171680
Depends on: 171680
Flags: blocking1.8b5?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta5
Attached patch patchSplinter Review
I will pref the desired behavior in the app level, in another bug.
Attachment #196737 - Flags: superreview?(roc)
Attachment #196737 - Flags: review?(mark)
Comment on attachment 196737 [details] [diff] [review]
patch

Mmmkay.  r=me as long as all.js gets defaults for withmetakey when
HORIZSCROLL_AVAILABLE is not defined.
Attachment #196737 - Flags: review?(mark) → review+
Blocks: 309345
Keywords: regression
Comment on attachment 196737 [details] [diff] [review]
patch

I see this code missed the great AppendLiteral sweep :-/ File a bug please.
Attachment #196737 - Flags: superreview?(roc) → superreview+
Checking in modules/libpref/src/init/all.js;
/cvsroot/mozilla/modules/libpref/src/init/all.js,v  <--  all.js
new revision: 3.599; previous revision: 3.598
done
Checking in content/events/src/nsEventStateManager.cpp;
/cvsroot/mozilla/content/events/src/nsEventStateManager.cpp,v  <-- 
nsEventStateManager.cpp
new revision: 1.614; previous revision: 1.613
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 196737 [details] [diff] [review]
patch

Approved per 9/26 bug triage meeting.
Attachment #196737 - Flags: approval1.8b5? → approval1.8b5+
Flags: blocking1.8b5? → blocking1.8b5+
1.8 branch:
Checking in modules/libpref/src/init/all.js;
/cvsroot/mozilla/modules/libpref/src/init/all.js,v  <--  all.js
new revision: 3.585.2.11; previous revision: 3.585.2.10
done
Checking in content/events/src/nsEventStateManager.cpp;
/cvsroot/mozilla/content/events/src/nsEventStateManager.cpp,v  <-- 
nsEventStateManager.cpp
new revision: 1.595.2.9; previous revision: 1.595.2.8
done
Keywords: fixed1.8
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.