309241 - a tmp file should be created if open an attachment of an local eml file

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Nian Liu(n/a in a long time)]

see 73757

When open an attachment of an local eml file, a tmp file should be created.

Comment 1

[Nian Liu(n/a in a long time)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, I can't figure out where the multipart channel comes from here. I also don't
think that mailnews should create file URIs in the case here.

however, it probably doesn't hurt to make this code work better in this case.
How about doing this the other way round, and checking whether the channel is a
file channel, and only treating it like a local file then?

Comment 3

[Nian Liu(n/a in a long time)]

(In reply to comment #2)
> ok, I can't figure out where the multipart channel comes from here.
The multipart channel comes from bug#284381. To treat an attachment of an local
eml file as a local file makes that patch not work for local file.
> I also don't
> think that mailnews should create file URIs in the case here.
> 
If save a eml file to local and open it, it should be, shouldn't it?
> however, it probably doesn't hurt to make this code work better in this case.
> How about doing this the other way round, and checking whether the channel is a
> file channel, and only treating it like a local file then?

I guess a file channel doesn't help here.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

hm, I see... ok...

> I guess a file channel doesn't help here.

I don't understand... your nsAttachmentChannel does not implement
nsIFileChannel. So, it seems like the code here could be something like:

 // In OnStartRequest
 nsCOMPtr<nsIFileChannel> fileChan(do_QueryInterface(aRequest));
 mIsFileChannel = fileChan != nsnull;

 // In LaunchWithApplication
 if (fileURL && mIsFileChannel) {
   // ...
 }

Comment 5

[Nian Liu(n/a in a long time)]

(In reply to comment #4)

> I don't understand... your nsAttachmentChannel does not implement
> nsIFileChannel. So, it seems like the code here could be something like:
my fault here, It should be mChannel implement nsIFileChannel when a local file
is opened, not nsAttachmentChannel.

> 
>  // In OnStartRequest
>  nsCOMPtr<nsIFileChannel> fileChan(do_QueryInterface(aRequest));
>  mIsFileChannel = fileChan != nsnull;
> 
>  // In LaunchWithApplication
>  if (fileURL && mIsFileChannel) {
>    // ...
>  }
> 

Comment 6

[Nian Liu(n/a in a long time)]

Attachment: patchv2

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 197131 [details] [diff] [review]
patchv2

look good, r=biesi. but please don't move the rv declaration.

however, I'm not a super-reviewer, switching that request to bz

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 197131 [details] [diff] [review]
patchv2

With biesi's nit, looks great.

Comment 9

[Pete Zha]

checked in