309292 - tab-drop-indicator shouldn't be an ID

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dorando]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7.10) Gecko/20050719 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.8b4) Gecko/20050919 Firefox/1.4

The tabbrowser.xml has two anonymous elements using an ID (tab-drop-indicator
and tab-drop-indicator-bar) which would prevent the usage of two <tabbrowser>s
in the same window (not that likely, but the toolkit shouldn't prevent it).

Reproducible: Always

Comment 1

[Dorando]

Attachment: Change tab-drop-indicator to a class and make it referenceable as mTabDropIndicatorBar

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 196776 [details] [diff] [review]
Change tab-drop-indicator to a class and make it referenceable as mTabDropIndicatorBar

mmm, right, we should probably get this on the branch as well

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/toolkit/content/widgets/tabbrowser.xml; new revision: 1.112;
mozilla/toolkit/themes/pinstripe/global/browser.css; new revision: 1.8;
mozilla/toolkit/themes/winstripe/global/browser.css; new revision: 1.10;

Comment 4

[Scott MacGregor]

Dorando, can you elaborate on what the user impact is here and why it should be
a blocker for the branch? Your comment "not that likeley..." makes me think that
this isn't a blocker issue this late in the game.

Comment 5

[Alfred Kayser]

Note that this also impacts the user themes, so having this for 1.5 is not nice,
forcing the theme maintainers to apply yet another 'worthless' change to their
themes...

Comment 6

[:Gavin Sharp [email: [e-mail]]]

1.8 Branch:
mozilla/toolkit/content/widgets/tabbrowser.xml; new revision: 1.103.2.5;
mozilla/toolkit/themes/pinstripe/global/browser.css; new revision: 1.7.4.1;
mozilla/toolkit/themes/winstripe/global/browser.css; new revision: 1.9.4.3;