309340 - All Bugzilla code should use the same format for the 'use lib' pragma

Status: RESOLVED WORKSFORME

(Bugzilla :: Bugzilla-General, defect)

Description

[Michel.J.van.der.List]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050909 Fedora/1.0.6-1.2.fc4 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050909 Fedora/1.0.6-1.2.fc4 Firefox/1.0.6

The various code in bugzilla uses different format for the 'use lib' pragma. I saw

use lib "."
use lib '.'
use lib qw(.)

I also sometime want to use code outside the standard perl libraries (in my
case, /usr/local/lib/perl). So, after checksetup.pl (which honors PERL5LIB),
I always have to fix the code as follows:

perl -pi -e 's@use lib \".\"@use lib qw\(.\)@' *.cgi *.pl
perl -pi -e 's@use lib '"'.'"'@use lib qw\(.\)@' *.cgi *.pl
perl -pi -e 's@use lib qw\(.\)@use lib qw\(. /usr/local/lib/perl\)@' *.cgi *.pl

It would be nice if that could be added to the checksetup.pl script
as an option.

Hopefully I did not miss something. I'm not exactly an expert...

Reproducible: Always

Comment 1

[Max Kanat-Alexander]

I agree. I also agree that it would be nice to have checksetup be able to change
the "use lib" pragma, but that would be a separate bug.

Comment 2

[Frédéric Buclin]

We now use

  use lib qw(. lib);

everywhere.